392175 - Move isViewable out of attachment.cgi + some other minor cleanup

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

Calling isViewable($attachment->contenttype) doesn't make sense. It should be $attachment->is_viewable. This will also help fixing bug 385338.

I also kill 2 useless routines from attachment.cgi, which are one-liners and used only once.

r+a=me as module owner.

Comment 1

[Frédéric Buclin]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.130; previous revision: 1.129
done
Checking in Bugzilla/Attachment.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment.pm,v  <--  Attachment.pm
new revision: 1.49; previous revision: 1.48
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.44; previous revision: 1.43
done
Checking in template/en/default/attachment/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v  <--  show-multiple.html.tmpl
new revision: 1.23; previous revision: 1.22
done