392264 - [windows] Download Manager shouldn't have margins

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Michael Ventnor]

Attachment: Patch

Notice how in the mockup, the download manager richlistbox takes up most of the window, it doesn't have any margins on the side. It also has a shading effect when going between the richlistbox and the area where the searchbox is.

I don't know if I should do the same for pinstripe, their DM already has no margins so I assume its been specially styled to match Safari's DM.

Comment 1

[Michael Ventnor]

Attachment: Shade image

This goes in toolkit/themes/winstripe/mozapps/downloads. Its just white and transparency so you won't see anything when viewing this image alone.

Comment 2

[Michael Ventnor]

Attachment: Screenshot

I might as well make a comparison screenshot. Left is without patch, right is with patch.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 276719 [details] [diff] [review]
Patch

sure.  Mano needs to look at this too (I don't trust my CSS-fu enough)

Comment 4

[Asaf Romano (gone)]

Couldn't you use border-image here?

Comment 5

[Asaf Romano (gone)]

Also, the "-moz-box-flex" rule on this hbox doesn't make sense, esp. because you specify its height.

Comment 6

[Asaf Romano (gone)]

(And, of course, how could you be sure the list background is white).

Comment 7

[Michael Ventnor]

(In reply to comment #4)
> Couldn't you use border-image here?

I don't think we support that. I looked up documentation for it and can't get it to work, even with the -moz prefix.

(In reply to comment #5)
> Also, the "-moz-box-flex" rule on this hbox doesn't make sense, esp. because
> you specify its height.

But we still need its width to be stretched by the width of the window.

(In reply to comment #6)
> (And, of course, how could you be sure the list background is white).

background-color. Maybe background-color !important just to be sure.

Comment 8

[Asaf Romano (gone)]

(In reply to comment #7)
> (In reply to comment #4)
> > Couldn't you use border-image here?
> 
> I don't think we support that. I looked up documentation for it and can't get
> it to work, even with the -moz prefix.
> 

Yeah, I didn't realize this is not yet checked in (see bug 378217).

> (In reply to comment #6)
> > (And, of course, how could you be sure the list background is white).
> 
> background-color. Maybe background-color !important just to be sure.
> 

We use system colors purposely.

Comment 9

[Michael Ventnor]

(In reply to comment #8)
> We use system colors purposely.

If I do use the system colour, there will be no way to do that fade effect under the box that was part of the mockup. If you're really certain about this, I guess I'll have to use a solid border-bottom...

Comment 10

[Michael Ventnor]

Attachment: Patch 2

Uses system colours, with the existing border now only used on the bottom. Needless to say, this doesn't require that shade image anymore.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 276752 [details] [diff] [review]
Patch 2

r=mano.

Comment 12

[Asaf Romano (gone)]

We can tweak this later (and may overkill it with a <canvas>), this will do for now.

Comment 13

[Shawn Wilsher :sdwilsh]

Thanks!

Checking in toolkit/themes/winstripe/mozapps/downloads/downloads.css;
new revision: 1.20; previous revision: 1.19

Comment 14

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081510 Minefield/3.0a8pre ID:2007081510

Verified

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

And now also verified with

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008010104 Minefield/3.0b3pre