392392 - I've typed http://gmail.com in the urlbar, but I don't see that in the history sidebar or history menu (due to redirect handing in places)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

I enter http://gmail.com in the urlbar, but I don't see that in the history sidebar or history menu (due to redirects?)

note, once bug #389491 lands, this will be a problem with the url bar autocomplete.

Comment 1

[(not reading, please use [e-mail] instead)]

this is a recent regression, and appears related to bug #375777

Comment 2

[(not reading, please use [e-mail] instead)]

> this is a recent regression, and appears related to bug #375777

after debugging, this is not a recent regression related to bug #375777.

Here's what's going on:

1) http://gmail.com is a redirect (to http://mail.google.com/mail/)

2) redirects are hidden (see this call to AddVisitChain() in http://lxr.mozilla.org/seamonkey/source/toolkit/components/places/src/nsNavHistory.cpp#3068)

3) our code in add visit will not unhide vists if they are redirects.  (http://lxr.mozilla.org/seamonkey/source/toolkit/components/places/src/nsNavHistory.cpp#1871)

I can reproduce this bug with a new profile, but I could not with an existing profile because http://gmail.com was already unhidden and we won't hide somethign that is already hidden.

what's next:

1)  see what fx 2 does and how it behaves.
2)  we might want to make it so "typed in" visits that redirect are not dinner.
3)  look into using a page url as the title when we don't have a title.

Comment 3

[(not reading, please use [e-mail] instead)]

> 1)  see what fx 2 does and how it behaves

testing it out, fx 2 will not add links I click on to http://gmail.com to history, but it will add them if I type them in.  I think we should make fx 3 do the same.

> 2)  we might want to make it so "typed in" visits that redirect are not dinner.

dinner?  I meant hidden.  Sheesh, it is only 2:30 pm and I'm already thinking about food.

> 3)  look into using a page url as the title when we don't have a title.

this is not necessary, we already do the right thing.

here comes a patch.

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 5

[(not reading, please use [e-mail] instead)]

fixed.

Checking in nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.155; previous revision: 1.154
done

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: test case

Comment 7

[(not reading, please use [e-mail] instead)]

for litmus:

1)  create a new profile
2)  load https://bugzilla.mozilla.org/attachment.cgi?id=277451
3)  click on the link, sign into gmail
4)  load https://bugzilla.mozilla.org/attachment.cgi?id=277451 again, click on the link again

you *should not* see "gmail.com" (http://gmail.com) in the history sidebar, history menu, or url bar autocomplete

now, type http://gmail.com in the url bar.

now you *should* see "gmail.com" (http://gmail.com) in the history sidebar, history menu, or url bar autocomplete

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Booyah.

http://litmus.mozilla.org/show_test.cgi?id=4582

in-litmus+ (you've been apprised).

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the steps to reproduce in comment 7 with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007090604 Minefield/3.0a8pre

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv