Closed Bug 392397 Opened 17 years ago Closed 17 years ago

Listbox inside a grid collapses the row next to it

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: asaf, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(2 files)

testcase
433 bytes, application/vnd.mozilla.xul+xml
Details
Proposed patch
2.27 KB, patch
enndeakin
: review+
bzbarsky
: superreview+
dbaron
: approval1.9+
Details | Diff | Splinter Review
Attached file testcase — 
Listbox inside a grid collapses the row next to it.

See testcase, if the center alignment is removed, the textfield shrinks a little instead.

WFM in 1.8.
Flags: blocking1.9?
This is a regression of bug 321073.
Depends on: 321073
Summary: Listbox inside a gridd collapses the row next to it → Listbox inside a grid collapses the row next to it
Attached patch Proposed patch — — Splinter Review 
If we're going to allow <grid> directly inside a <rows> (i.e. without an intervening <vbox>) then we need to fix up some other counts too.

Note that the row is a "bogus" row as per nsGridRowGroupLayout::BuildRows
Assignee: jag → neil
Status: NEW → ASSIGNED
Attachment #277099 - Flags: superreview?(bzbarsky)
Attachment #277099 - Flags: review?(enndeakin)
Comment on attachment 277099 [details] [diff] [review]
Proposed patch

Trusting Enn here to actually review correctness....
Attachment #277099 - Flags: superreview?(bzbarsky) → superreview+
Attachment #277099 - Flags: review?(enndeakin) → review+
Comment on attachment 277099 [details] [diff] [review]
Proposed patch

This fixes a regression that's blocking a Firefox3 UI-wanted feature.
Attachment #277099 - Flags: approval1.9?
Comment on attachment 277099 [details] [diff] [review]
Proposed patch

a1.9=dbaron
Attachment #277099 - Flags: approval1.9? → approval1.9+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: blocking1.9?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: