392461 - pref-locale broken on trunk (causing nsPrefWindow.js warning in error console)

Status: RESOLVED INVALID

(SeaMonkey :: Preferences, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007081605 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Open 'Edit > Preferences...', each time:
{{
Warning: reference to undefined property Components.interfaces.nsIChromeRegistrySea
Source File: chrome://communicator/content/pref/nsPrefWindow.js
Line: 101
}}

Code is:
{{
nsPrefWindow.prototype =
  {
    onload:
      function ()
        {
          try 
            {
              this.pref = Components.classes["@mozilla.org/preferences-service;1"].getService(Components.interfaces.nsIPrefService).getBranch(null);
              this.chromeRegistry = Components.classes["@mozilla.org/chrome/chrome-registry;1"].getService(Components.interfaces.nsIChromeRegistrySea);   // 101
              this.observerService = Components.classes["@mozilla.org/observer-service;1"].getService(Components.interfaces.nsIObserverService);
            }
          catch(e) 
            {
              dump("*** Failed to create prefs object\n");
              return;
            }
        },
}}

This line is blamed to
{{
1.54	bsmedberg%covad.net	2006-05-16 19:22	 	Merge bug 246014 from the aviary branch, splitting nsIXULChromeRegistry into a separate piece for seamonkey-only methods.
}}

This might be a "recent" regression ?

Comment 1

[Serge Gautherie (:sgautherie)]

PS:
Odd, this happens with only one of my profiles :-/
I would have to narrow down the cause...

Comment 2

[Mark Banner (:standard8)]

This is a problem due to the fact the langauges pane doesn't support switching langauges trunk style. Bug 377881 would probably reimplement the necessary code, so marking as a dep.

Comment 3

[Axel Hecht [:Pike]]

Unmarking bug 377881 as a dep. SeaMonkey js errors shouldn't depend on toolkit features, and I'm pretty sure that toolkit is not going to implement nsIChromeRegistrySea.

Adding Benjamin to verify that assumption.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> Unmarking bug 377881 as a dep. SeaMonkey js errors shouldn't depend on toolkit
> features, and I'm pretty sure that toolkit is not going to implement
> nsIChromeRegistrySea.
> Adding Benjamin to verify that assumption.

I never said that toolkit is going to implement nsIChromeRegistrySea, or that the toolkit feature mentioned in bug 377881 will be implemented.

What I was trying to point out is that we're hoping to get bug 377881 to be fixed, at which point we won't need some of our langauges pane (the cause of this error), and currently there is no point in us doing anything until we know what's happening in bug 377881 - hence the dependency.

Comment 5

[Robert Kaiser]

I have code in my private tree for replacing language switching if bug 377881 won't be fixed - this will be only a dropdown menu with two labels, so no need for it to take a full prefpane. pref-appearances get a bit crowded though from what I see. We'll try to figure out a good place for it.

Comment 6

[Serge Gautherie (:sgautherie)]

(Filter "spam" on 'prefs-nobody-20080612'.)

Comment 7

[Ian Neal]

Robert, is this still even valid as you have moved the pref into pref-appearances on the new pref window?

Comment 8

[Robert Kaiser]

Ian, right, this has been invalidated by bug 411215