392505 - nsNPObjWrapper::GetNewOrUsed() removes PLDHash entries from the wrong table if OOM (JS)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Johnny Stenback (:jst)]

Attachment: Remove entry from the right hash.

Found by code inspection around the point of a crash seen by a plugin developer. Obvious patch attached (if you look above the context in the diff you'll see that the entry being removed comes from sNPObjWrappers, not sJSObjWrappers).

Comment 1

[Daniel Veditz [:dveditz]]

Comment on attachment 277005 [details] [diff] [review]
Remove entry from the right hash.

approved for 1.8.1.7, a=dveditz

Comment 2

[Johnny Stenback (:jst)]

Attachment: Trunk version.

Peter, this is the same patch with a couple of additional cleanups and an unnecessary error check removed when calling JS_SetPrivate() (which can not fail).

Comment 3

[Johnny Stenback (:jst)]

Fixed on trunk.

Comment 4

[Johnny Stenback (:jst)]

This landed on the 1.8 branch a long time ago, just forgot to mark it :(