Closed Bug 392505 Opened 14 years ago Closed 14 years ago
NPObj Wrapper::Get New Or Used() removes PLDHash entries from the wrong table if OOM (JS)
Found by code inspection around the point of a crash seen by a plugin developer. Obvious patch attached (if you look above the context in the diff you'll see that the entry being removed comes from sNPObjWrappers, not sJSObjWrappers).
Attachment #277005 - Flags: review?(mrbkap) → review+
Attachment #277005 - Flags: superreview?(dveditz) → superreview+
Comment on attachment 277005 [details] [diff] [review] Remove entry from the right hash. approved for 126.96.36.199, a=dveditz
Attachment #277005 - Flags: approval188.8.131.52? → approval184.108.40.206+
Peter, this is the same patch with a couple of additional cleanups and an unnecessary error check removed when calling JS_SetPrivate() (which can not fail).
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This landed on the 1.8 branch a long time ago, just forgot to mark it :(
You need to log in before you can comment on or make changes to this bug.