Last Comment Bug 392522 - Integrity hashes must be updated when passwords are changed.
: Integrity hashes must be updated when passwords are changed.
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: x86 Linux
: -- normal (vote)
: 3.12
Assigned To: Robert Relyea
:
Mentors:
Depends on:
Blocks: 391291
  Show dependency treegraph
 
Reported: 2007-08-16 17:07 PDT by Robert Relyea
Modified: 2007-09-12 13:20 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Update integrity checks on password change (14.44 KB, patch)
2007-08-17 17:29 PDT, Robert Relyea
julien.pierre: review+
Details | Diff | Review

Description Robert Relyea 2007-08-16 17:07:23 PDT
The password change code was not updated when the integrity hash code was added.

all.sh failed to catch this case, (fortunately I caught it by inspection).

We need to correct this problem and update all.sh to include the appropriate test case.
Comment 1 Robert Relyea 2007-08-17 17:29:18 PDT
Created attachment 277183 [details] [diff] [review]
Update integrity checks on password change

This patch does 2 things:

1) updates the tests to uncover and verify the original problem.
2) update the macs on password update.


Note the the former fixes the problem in the password update test that prevented us from seeing the sdr update problem.
Comment 2 Robert Relyea 2007-08-22 13:50:59 PDT
Comment on attachment 277183 [details] [diff] [review]
Update integrity checks on password change

Oops, didn't have a reviewer assigned.
Comment 3 Robert Relyea 2007-09-12 13:20:54 PDT
check in:

(+207/78) Lines changed.
When 	 Who 	File 	Rev 	+/- 	Description
2007-09-12 09:42	rrelyea%redhat.com 	mozilla/security/nss/tests/cert/cert.sh 	1.46 	29/26  	
2007-09-12 09:40	rrelyea%redhat.com 	mozilla/security/nss/lib/softoken/sftkdb.c 	1.9 	3/3 
2007-09-12 09:40	rrelyea%redhat.com 	mozilla/security/nss/lib/softoken/sftkdbti.h 	1.2 	5/0 
2007-09-12 09:40	rrelyea%redhat.com 	mozilla/security/nss/lib/softoken/sftkpwd.c 	1.2 	170/49 

Note You need to log in before you can comment on or make changes to this bug.