Integrity hashes must be updated when passwords are changed.

RESOLVED FIXED in 3.12

Status

NSS
Libraries
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Robert Relyea, Assigned: Robert Relyea)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
The password change code was not updated when the integrity hash code was added.

all.sh failed to catch this case, (fortunately I caught it by inspection).

We need to correct this problem and update all.sh to include the appropriate test case.
(Assignee)

Comment 1

10 years ago
Created attachment 277183 [details] [diff] [review]
Update integrity checks on password change

This patch does 2 things:

1) updates the tests to uncover and verify the original problem.
2) update the macs on password update.


Note the the former fixes the problem in the password update test that prevented us from seeing the sdr update problem.
Attachment #277183 - Flags: review?
(Assignee)

Comment 2

10 years ago
Comment on attachment 277183 [details] [diff] [review]
Update integrity checks on password change

Oops, didn't have a reviewer assigned.
Attachment #277183 - Flags: review? → review?(julien.pierre.boogz)

Updated

10 years ago
Attachment #277183 - Flags: review?(julien.pierre.boogz) → review+
(Assignee)

Comment 3

10 years ago
check in:

(+207/78) Lines changed.
When 	 Who 	File 	Rev 	+/- 	Description
2007-09-12 09:42	rrelyea%redhat.com 	mozilla/security/nss/tests/cert/cert.sh 	1.46 	29/26  	
2007-09-12 09:40	rrelyea%redhat.com 	mozilla/security/nss/lib/softoken/sftkdb.c 	1.9 	3/3 
2007-09-12 09:40	rrelyea%redhat.com 	mozilla/security/nss/lib/softoken/sftkdbti.h 	1.2 	5/0 
2007-09-12 09:40	rrelyea%redhat.com 	mozilla/security/nss/lib/softoken/sftkpwd.c 	1.2 	170/49 
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.