Closed Bug 392522 Opened 17 years ago Closed 17 years ago

Integrity hashes must be updated when passwords are changed.

Categories

(NSS :: Libraries, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rrelyea, Assigned: rrelyea)

References

Details

Attachments

(1 file)

The password change code was not updated when the integrity hash code was added.

all.sh failed to catch this case, (fortunately I caught it by inspection).

We need to correct this problem and update all.sh to include the appropriate test case.
This patch does 2 things:

1) updates the tests to uncover and verify the original problem.
2) update the macs on password update.


Note the the former fixes the problem in the password update test that prevented us from seeing the sdr update problem.
Attachment #277183 - Flags: review?
Comment on attachment 277183 [details] [diff] [review]
Update integrity checks on password change

Oops, didn't have a reviewer assigned.
Attachment #277183 - Flags: review? → review?(julien.pierre.boogz)
Attachment #277183 - Flags: review?(julien.pierre.boogz) → review+
check in:

(+207/78) Lines changed.
When 	 Who 	File 	Rev 	+/- 	Description
2007-09-12 09:42	rrelyea%redhat.com 	mozilla/security/nss/tests/cert/cert.sh 	1.46 	29/26  	
2007-09-12 09:40	rrelyea%redhat.com 	mozilla/security/nss/lib/softoken/sftkdb.c 	1.9 	3/3 
2007-09-12 09:40	rrelyea%redhat.com 	mozilla/security/nss/lib/softoken/sftkdbti.h 	1.2 	5/0 
2007-09-12 09:40	rrelyea%redhat.com 	mozilla/security/nss/lib/softoken/sftkpwd.c 	1.2 	170/49 
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: