Closed
Bug 392646
Opened 18 years ago
Closed 18 years ago
Remove SearchTextField and friends
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.8)
Attachments
(1 file)
|
29.42 KB,
patch
|
mark
:
superreview+
|
Details | Diff | Splinter Review |
Now that we are all-NSSearchField, we can remove all the hand-rolled stuff. Specifically:
src/browser/SearchTextField.h
src/browser/SearchTextField.m
src/browser/SearchTextFieldCell.h
src/browser/SearchTextFieldCell.m
src/browser/STFPopUpButtonCell.h
src/browser/STFPopUpButtonCell.m
resources/images/chrome/SearchCancel.tiff
resources/images/chrome/SearchCancel_small.tiff
resources/images/chrome/SearchLeft.tiff
resources/images/chrome/SearchLeft_small.tiff
resources/images/chrome/SearchMiddle.tiff
resources/images/chrome/SearchMiddle_small.tiff
resources/images/chrome/SearchNoPopUp.tiff
resources/images/chrome/SearchPopUp.tiff
resources/images/chrome/SearchPopUp_small.tiff
resources/images/chrome/SearchRight.tiff
resources/images/chrome/SearchRight_small.tiff
There's also the associated Xcode project changes and one place I forgot to remove an import of STFPopUpButtonCell.h, which is in the patch (the file removals aren't there, since that's not very interesting, but it's ~1000 lines of code gone, and close to 100k of images).
Attachment #277131 -
Flags: superreview?(mark)
|
||
Updated•18 years ago
|
Attachment #277131 -
Flags: superreview?(mark) → superreview+
|
Assignee | |
Comment 1•18 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
Farewell SearchTextField; you served us faithfully.
You need to log in
before you can comment on or make changes to this bug.
Description
•