392669 - [Today Pane] Image of toolbarbutton for today pane should be exchanged

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Berend Cornelius]

The current image of the toolbar buutton for the today pane is merely a place holder and should be exchanged.

Comment 1

[Berend Cornelius]

Attachment: zip-file containing the images for the new toolbar-button

zip file contains updated imagelists of all calendar toolbar images for both 'winstripe' and 'pinstripe' and in both sizes 'small" and 'large'. The images for the today-pane is located on the very right side of the imagelists. To add the images to the project just unzip the zip file from the calendar folder from where all imagelists will then be extracted to their destination folder.

Comment 2

[Berend Cornelius]

Attachment: patch with adapted css files to refer to the new images

I updated the respective css files. I did not change the indentation to keep the files consistent. As I have not yet tested the images under Mac I will be asking for a review later.

Comment 3

[Michael Büttner (no reviews TFN)]

I just came across this Bug and saw that the patch is basically ready for review. I just tried it and found that it just works as advertised..

Comment 4

[Berend Cornelius]

Comment on attachment 277254 [details] [diff] [review]
patch with adapted css files to refer to the new images

I tested the patch under MacOSX and found it looked fine. mickey, could you review?

Comment 5

[Michael Büttner (no reviews TFN)]

Comment on attachment 277254 [details] [diff] [review]
patch with adapted css files to refer to the new images

r=mickey based on my previous comment.

Comment 6

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH

Comment 7

[Andreas Treumann]

Verifies in lightning build 2007082204 -> task is fixed.

Comment 8

[Simon Paquet [:sipaq]]

Sorry for raising this issue so late in the game, but I must protest against the new image for the Today pane. It is not i18n-friendly as it only corresponds to users, using western arabic numerals.

This is exactly the reason why we did not use numbers in our day/week/month view icons.

Therefore I'm reopening this bug.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

How much of a problem is that really, given that we only support calendar scales that are mostly western? We don't support any other era's.

Comment 10

[Christian Jansen]

Simon,
in general you are right, but I don't see this as blocker, till 1.0 is released. 
Anyhow, if there is a broad wish to change it, we can go with a more nutral one.

From my point of viw it would be perfect to display an icon which change its content, date depending.

Comment 11

[Simon Paquet [:sipaq]]

mvl, you'e right that at the moment this isn't a huge problem. My point is, that we have made the decision in the past, to keep our UI l10n and i18n-agnostic.

I was not aware of a change of this policy. If we decide to change that policy, fine, but someone should propose a change first and then change the implementation and not the other way around.

Comment 12

[Berend Cornelius]

in reply to comment #10
> From my point of viw it would be perfect to display an icon which change its
> content, date depending.

I suggest to set up a new issue to implement this feature. This could be realized by applying a stack element to the the toolbar button with the image on the bottom layer and a text box with the (localizeable!) date at the top layer.

Comment 13

[Simon Paquet [:sipaq]]

Spinoff bug 393763 filed. Marking as FIXED again

Comment 14

[Martin Schröder [:mschroeder]]

VERIFIED with Lightning 0.7pre (2007082803) on WinXP.