392718 - With beautified ftp listings, long filenames are truncated, making them hard to read

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Steve England [:stevee]]

Attachment: Shows before and after; in after note truncated filenames

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007081716 Minefield/3.0a8pre ID:2007081716

After the landing of bug 294800, long filenames are now truncated which makes it hard to distinguish between such filenames that are similar, and also makes it sometimes hard to see what filetype a file is.

This makes navigating and downloading files using ftp harder.

Comment 1

[Dão Gottwald [:dao]]

Attachment: WIP

I still have to test this, since my c++ skills are not mature.

Comment 2

[Michael Ventnor]

Attachment: Patch

This does the same thing but uses the Replace function (thus saving codesize). I hope you don't mind Dao...

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 277257 [details] [diff] [review]
Patch

The surrogate checks are needed _after_ cutting. Same for calling nsEscapeHTML2, I think, in order to not truncate HTML entities.

Comment 4

[Michael Ventnor]

If we want to do escaping after the cutting happens, I guess your method is better. TBH I'm not very good at this either :)

Comment 5

[Boris Zbarsky [:bzbarsky]]

For what it's worth, this code is making very poor use of screen real estate.  Even given the smallish size of my windows (about 1000px wide), and the huge amounts of horizontal whitespace the current design puts in (easily a third of the window width), only about half of the space for the filename is being used before we start truncating.  It looks pretty silly to have those truncated filenames while there's a bunch of space available.

Can we either significantly increase the truncation length, or at least make it resolution-dependent (maybe by moving the truncation into the script, though that may have performance issues) or something?  

Comment 6

[Dão Gottwald [:dao]]

Attachment: first attempt

I think this basically solves the problem. But we can keep the bug open for more tweaks.

Comment 7

[Boris Zbarsky [:bzbarsky]]

It doesn't really solve the problem I'm running into....  Do you want a separate bug on that?

Comment 8

[Dão Gottwald [:dao]]

Sure, a separate bug might be appropriate in order to keep different issues apart. In my book, the main problem here is that file extensions have been cut off.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Filed bug 393681.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 277300 [details] [diff] [review]
first attempt

>Index: nsIndexedToHTML.cpp
>+            if (NS_IS_LOW_SURROGATE(descriptionAffix.Last()))

s/Last/First/ right?

With that change, r+sr+a=bzbarsky

Comment 11

[Dão Gottwald [:dao]]

Attachment: for checkin

yeah, must be First()

Comment 12

[Phil Ringnalda (:philor)]

netwerk/streamconv/converters/nsIndexedToHTML.cpp 1.83

Comment 13

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007082603 Minefield/3.0a8pre ID:2007082603
VERIFIED