392737 - Event dialog: No 'save and close' function in the new event file menu

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[juergen.edner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: Thunderbird v2.0.0.6 (20070728) / Lightning v0.7pre (2007081804)

In the 'new event' dialog it is not possible to choose the 'save and close' function via the menu bar/file menu, although a 'save and close' button exists in toolbar.

Reproducible: Always

Steps to Reproduce:
1. create a new event
2. open the file menu from the menu bar to save and close the newly created event.
3. 
Actual Results:  
the desired function doesn't exist in the file menu.

Expected Results:  
It should also be possible to choose 'save and close' via the file menu.

Comment 1

[Stefan Sitter [:ssitter]]

Christian, what is your opinion on this enhancement request?

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Oops, sorry, my bad, returning to the right component, awfully sorry about stomping your target milestone, please send hatemail to this address :(

Comment 3

[Tobias (:Tobbi) Markus]

Attachment: [after beta] Adds a menu item to the file menu as well as the translations

First patch

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 406069 [details] [diff] [review]
[after beta] Adds a menu item to the file menu as well as the translations

I'll review this after the beta, since it contains strings.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 406069 [details] [diff] [review]
[after beta] Adds a menu item to the file menu as well as the translations

It seems your patch contains some tabs that need to be converted to spaces. Please correct this in all chunks.

>+		<key id="saveandclose-key"
>+			 modifiers="accel"
>+			 key="L"
>+			 command="cmd_accept"/>
The "key" needs a l10n string too.


> <!ENTITY  event.menu.item.delete.label                    "Deleteâ¦">
It seems your editor/patch programm has saved this file in a different character encoding than UTF-8. Please make sure the file is saved in UTF-8.


r- to get a new patch, I'll quickly r+ it afterwards.

Thanks for looking into this!

Comment 6

[Tobias (:Tobbi) Markus]

Attachment: v.2: Adding Save and close to the Event file menu

v2, addressing the above comments.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 432850 [details] [diff] [review]
v.2: Adding Save and close to the Event file menu

Looks good, r=philipp

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/e634ac0b29ab>

-> FIXED