Closed Bug 392846 Opened 17 years ago Closed 17 years ago

Do not send hello extensions when using SSL v3.0

Categories

(NSS :: Libraries, defect, P2)

Product:
NSS
Component:
Libraries
Version:
3.11.7
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
3.11.8

People

(Reporter: KaiE, Assigned: nelson)

References

Details

Attachments

(1 file)

tested patch v1
848 bytes, patch
KaiE
: review+
julien.pierre
: review+
Details | Diff | Splinter Review 
In order to fix an issue with Thunderbird and the matrixssl library, it has been proposed to never send hello extensions when using SSL v3.0

See bug 368611 and the discussions around the report from Filippo.
Blocks: 368611
Attached patch tested patch v1 — — Splinter Review 
Kai, Does this patch solve the problem?
Assignee: nobody → nelson
Status: NEW → ASSIGNED
Attachment #277361 - Flags: review?
Comment on attachment 277361 [details] [diff] [review]
tested patch v1

This patch works great!

r=kengert
Attachment #277361 - Attachment description: untested patch v1 → tested patch v1
Attachment #277361 - Flags: review? → review+
Setting bug to 3.11.x branch, it would be good to get this patch on that branch and include it the next time the stable Thunderbird/Firefox 2.x branches pick up a newer NSS release.
Version: trunk → 3.11.7
Comment on attachment 277361 [details] [diff] [review]
tested patch v1

Who should do the second review for 3.11.x?
Attachment #277361 - Flags: review?
Comment on attachment 277361 [details] [diff] [review]
tested patch v1

I'll ask Julien for a second review on this one-line patch.
Attachment #277361 - Flags: review? → review?(julien.pierre.boogz)
On trunk:
Checking in ssl3con.c; new revision: 1.103; previous revision: 1.102
Priority: -- → P2
Target Milestone: --- → 3.11.8
Attachment #277361 - Flags: review?(julien.pierre.boogz) → review+
This needs to get checked in on NSS 3.11.x branch. Let me know if I should do it.

On branch:
Checking in ssl3con.c; new revision: 1.76.2.21; previous revision: 1.76.2.20
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: