392855 - [Today Pane] 'Show Today Pane' button not available with fresh profile

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Michael Büttner (no reviews TFN)]

The 'Show Today Pane' button is dynamically added to Thunderbird's mail toolbar when Lightning runs for the first time on the given profile. The today pane remembers internally that it already added the button to the toolbar in order to prevent further modifications in case we're faced with a user customized toolbar.

Unfortunately this doesn't work with a fresh profile. Just create a new profile and install Lightning, the 'Show Today Pane' button won't be displayed on the main toolbar. Restoring the default set of the toolbar will make the button show up.

Comment 1

[Berend Cornelius]

I could not reproduce this behavior on my system (Solaris Intel).

Comment 2

[Stefan Sitter [:ssitter]]

I can confirm but with slightly different STR using Thunderbird 2.0.0.7pre (20070820) with Lightning 0.7pre (2007082004) on Windows 2000.

Steps to Reproduce:
1. Create new profile and start Thunderbird
2. Install Lightning and restart Thunderbird -> Button is shown
3. Restart Thunderbird -> Button is not shown anymore

Comment 3

[Berend Cornelius]

I find this behavior quite awkward, but following the procedure that Stefan described in comment #2 I could reproduce the bug. I think this definitely blocks 0.7 release.

Comment 4

[Daniel Boelzle [:dbo]]

not going to make 0.7

Comment 5

[Sven Giermann]

I found the necessary bits and pieces in persistCurrentSets():
http://lxr.mozilla.org/mozilla1.8/source/mail/base/content/customizeToolbar.js#176

As this code is being moved in patches for bug 389150, I am setting dependecy and would like to fix this together with bug 389150.

If anyone disagrees, I could also attach the appropriate patch here.

Comment 6

[Berend Cornelius]

Attachment: patch v. #1

I hope that this patch fixes the problem. It is based on a patch from Sven that he implemented for "Bug 389150 – Display Today Pane with Task List in Calendar mode too". 
Sven, as the patch is majorly based on your idea you can also assign the issue to yourself, if you like to and/or modify the patch as you think it's best. Otherwise I would ask Andreas to test this before the review.

One last note: I currently do not have a Mac available otherwise I could text if this patch also fixes bug 394136 [Today Pane] Under Macintosh the toolbar button is placed at the end of the mail toolbar.

Comment 7

[Sven Giermann]

@Berend:
I could reproduce the problem described in bug 389150 comment #70 with my version, which is definitely fixed with yours here.

As this is just a clean-up of your 'ltnAddButtonToDefaultSet' which worked for several months and the use of this also for 'currentSet', it should not hurt any more. I found the description at MDC [1], that it is safe to just modify this property instead of 'insertChild' etc.
With your additional check for an empty string it works for me.

You did not request review until now and I'm no reviewer, but you would get my r+ ;-)

[1] http://developer.mozilla.org/en/docs/XUL:Property:currentSet

Comment 8

[Berend Cornelius]

Comment on attachment 316441 [details] [diff] [review]
patch v. #1

Sven, thank you for testing it again and thank you also for the link (that also finally explained to me that the currentSet Attribute is not automatically resynched with the property).

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 316441 [details] [diff] [review]
patch v. #1

r=sven based on comment 7.

Comment 10

[Berend Cornelius]

I gave the patch to Andreas to test it and he found it was Ok.
Patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 11

[Andreas Treumann]

Checked in lightning 2008042719 -> VERIFIED