Closed
Bug 392882
Opened 17 years ago
Closed 17 years ago
ActionMonkey: Firefox build is broken
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
Attachments
(1 file)
|
3.14 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
MMgc isn't in the include path for all the modules that include "jscntxt.h".
It's not as simple as copying all the MMgc headers into ${OBJDIR}/dist/include/js. Those headers must always be included with the same set of MMgc-related defines, especially in debug mode; otherwise you can have linker problems or just crashes.
|
Assignee | |
Comment 1•17 years ago
|
||
bsmedberg suggests that these flags should go wherever JS_THREADSAFE goes, which makes sense.
|
|
Assignee | |
Comment 3•17 years ago
|
||
Turned out to be slightly more work than that.
(I ran across bug 394447 while doing this.)
|
||
Updated•17 years ago
|
Attachment #279103 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•