392883 - ActionMonkey: remove gcThingFlags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

They're just taking up space.

* The type bits: use the vtable.  jsdoubles don't have a vtable, so they'll need a workaround. (Note: The cycle collector sneakily uses these bits, in nsXPConnect.cpp; it will be changed too.)

* The GCF_LOCK bit: mainly replaced by allowing MMgc to scan rt->gcLocksHash, bug 389832. There is also a string optimization that uses this bit. It's yet to be determined what to do about that.

* The GCF_MUTABLE bit: move into JSString; see bug 391290.

* The GCF_SYSTEM bit: move into JSObject. Details to be determined.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

This is fairly trivial now--Igor did all the hard work in trunk!

Thanks, Igor.

Comment 2

[Igor Bukanov]

(In reply to comment #0)
> * The type bits: use the vtable.  jsdoubles don't have a vtable, so they'll
> need a workaround. (Note: The cycle collector sneakily uses these bits, in
> nsXPConnect.cpp; it will be changed too.)
> 
> * The GCF_LOCK bit: mainly replaced by allowing MMgc to scan rt->gcLocksHash,
> bug 389832. There is also a string optimization that uses this bit. It's yet to
> be determined what to do about that.

That can be replaced by a hash table and an explicit tracing of atomized strings to avoid an extra hash table entries for them.

Comment 3

[Jason Orendorff [:jorendorff]]

The string optimization appears to be gone in trunk, and the locking functionality is already long gone in ActionMonkey branch (bug 389832).  So there was nothing left to replace.

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: changes from v1 to v2

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: v2 - also deletes GCX_ constants

Sorry for the noise, igor - I just realized I didn't delete as much stuff as I could've.

Comment 6

[Jason Orendorff [:jorendorff]]

Attachment: v3 - for checkin

Same as v2 except for merges

Comment 7

[Jason Orendorff [:jorendorff]]

Pushed changeset e92ee8ec06d5 to actionmonkey branch.