392901 - UI dialogs should cancel pending calendar operations when closing

Status: NEW

(Calendar :: General, defect)

Description

[Daniel Boelzle [:dbo]]

Since calIOperation (bug 329034) has landed, UI code should cancel any pending calendar operations on closing dialogs, so the providers don't call on dead JS contexts.

Comment 1

[Stefan Sitter [:ssitter]]

Could you be more specific what you mean? 
For example what about "Save and Close" in the Event Dialog? Should the closing dialog cancel the write operation started a few moments before?

Comment 2

[Daniel Boelzle [:dbo]]

(In reply to comment #1)
> Could you be more specific what you mean? 
> For example what about "Save and Close" in the Event Dialog? Should the closing
> dialog cancel the write operation started a few moments before?
It's about that you are running into js exceptions if XUL code is called (async) if the enclosing dialog has already been disposed. If XUL code runs async operations and is closed, it has to dispose a pending operation to avoid being called when the operation has completed.
For the specific task of "Save And Close" that you've mentioned, I see thus only three options:
1) Postpone closing until the operation has completed.
2) Don't pass a listener.
3) Pass a listener that is hosted outside of the specific js context.

Comment 3

[Daniel Boelzle [:dbo]]

should better read: "...and the enclosing dialog has already been disposed".