Closed
Bug 393031
Opened 17 years ago
Closed 17 years ago
remove obsolete file: modules/libimg/png/pngasmrd.h
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha8
People
(Reporter: glennrp+bmo, Assigned: glennrp+bmo)
Details
Attachments
(1 file)
601 bytes,
patch
|
tor
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
The file mozilla/modules/libimg/png/pngasmrd.h has been obsolete and unused for about 5 years. It should be removed.
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•17 years ago
|
||
Comment 2•17 years ago
|
||
Were you planning on asking for r/sr on this?
Assignee | ||
Updated•17 years ago
|
Attachment #277652 -
Flags: superreview?(tor)
Attachment #277652 -
Flags: review?(tor)
Attachment #277652 -
Flags: superreview?(tor)
Attachment #277652 -
Flags: superreview+
Attachment #277652 -
Flags: review?(tor)
Attachment #277652 -
Flags: review+
Assignee | ||
Updated•17 years ago
|
Whiteboard: checkin to trunk requested
Comment 3•17 years ago
|
||
Glenn: We have a keyword you can use now to indicate that a patch on the bug needs to be checked in: "checkin-needed".
Keywords: checkin-needed
Whiteboard: checkin to trunk requested
Comment 4•17 years ago
|
||
Removing modules/libimg/png/pngasmrd.h; /cvsroot/mozilla/modules/libimg/png/pngasmrd.h,v <-- pngasmrd.h new revision: delete; previous revision: 3.3 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M8
Assignee | ||
Comment 5•17 years ago
|
||
How about removing the file from the branch, too?
Comment 6•17 years ago
|
||
What's the point?
Assignee | ||
Comment 7•17 years ago
|
||
Only to reduce clutter. I could live with it remaining there.
Comment 8•17 years ago
|
||
The branch will die eventually, and getting stuff checked in there is not easy; I don't think it's worth the effort.
Assignee | ||
Comment 9•17 years ago
|
||
OK. Thanks for the checkin. Verified that pngasmrd.h is gone from trunk.
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•17 years ago
|
Attachment #277652 -
Attachment description: Removes pngasmrd.h (use patch -E) → Removes pngasmrd.h (use patch -E) (checked in)
You need to log in
before you can comment on or make changes to this bug.
Description
•