393105 - [Proto] Reminder dialog: localizability issues due to fixed width

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: screenshot of issue

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.7pre) Gecko/20070821 Calendar/0.7pre

The dialog for editing custom reminders has a localizability issue. 
If the translation is more verbose/longer than en-US translation 

1. The button label text overrun the button dimensions
2. The text in the list control is cut off

See attached screenshot showing issue with dummy translation

Expected Results:
1. Buttons enlarges and the label text fits the button dimensions
2. Buttons are aligned on the right side and the list control takes up all the remaining space allowing to view longer text too.

Comment 1

[cmtalbert]

If we can't fit text in English, then we'll never fit text in Spanish or German.  This has to block.

Comment 2

[Simon Paquet [:sipaq]]

A simple

- <listbox id="reminder-listbox" seltype="single" onselect="onReminderSelected()">
+ <listbox id="reminder-listbox" seltype="single" onselect="onReminderSelected()" flex="1">

in line 71 of sun-calendar-event-dialog-reminder.xul fixes things for me.

If someone wants to whip up a quick patch, feel free to do so. Otherwise I'll do it on the weekend.

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Comment 4

[cmtalbert]

Comment on attachment 278082 [details] [diff] [review]
Patch v1

r=ctalbert

thanks!

Comment 5

[Simon Paquet [:sipaq]]

Patch checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 6

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.0; lt; rv:1.8.1.7pre) Gecko/20070825 Calendar/0.7pre.