Closed Bug 393149 Opened 12 years ago Closed 12 years ago

Some registry keys aren't removed under HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\

Categories

(Toolkit :: NSIS Installer, defect)

x86
Windows Vista
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla1.9alpha8

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

(Keywords: verified1.8.1.8)

Attachments

(3 files)

I missed a short path condition in RegCleanMain when fixing bug 389244. Patch coming up
Attached patch simple patchSplinter Review
Attachment #277676 - Flags: review?(sspitzer)
After this lands...

Steps for verification (similar to bug 389244)

1. Open reg file to import the registry entries
2. Open regedit.exe and navigate to HKLM\Software\Mozilla
3. Note the multiple entries for Minefield
4. Run a latest nightly installer
5. Select custom during the install
6. Select C:\Yabba Dabba Do\Mozilla Firefox as the installation directory
7. After the install completes verify the additional registry entries noted in
step 3 are no longer present

Extra reg entry names
Minefield (3.0a5pre)
Minefield (3.0a6pre)
Attachment #277676 - Flags: review?(sspitzer) → review+
Checked in to trunk
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh,v  <--  common.nsh
new revision: 1.21; previous revision: 1.20
done
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Tomcat, could you please verify this is fixed? Steps for verifying are in comment #2. You might want to verify bug 389244 at the same time. Thanks!
No longer blocks: 389244
Depends on: 389244
(In reply to comment #4)
> Tomcat, could you please verify this is fixed? Steps for verifying are in
> comment #2. You might want to verify bug 389244 at the same time. Thanks!

Hi Rob, no problem. 
Also verified on vista with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007082205 Minefield/3.0a8pre and the steps to reproduce from this bug. After install of 2007082205 the addional entries in the Registry and under Control Panel\Programs\Programs and Features are gone.

- Verified
Status: RESOLVED → VERIFIED
Comment on attachment 277676 [details] [diff] [review]
simple patch

This is a followup to bug 389244 for one more directory path comparison.
Attachment #277676 - Flags: approval1.8.1.7?
Flags: blocking1.8.1.7?
Comment on attachment 277676 [details] [diff] [review]
simple patch

approved for 1.8.1.7, a=dveditz for release-drivers
Attachment #277676 - Flags: approval1.8.1.7? → approval1.8.1.7+
Flags: blocking1.8.1.7? → blocking1.8.1.7+
Checked in to MOZILLA_1_8_BRANCH for 1.8.1.7 (e.g. Firefox 2.0.0.7)

Checking in mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh,v  <--  common.nsh
new revision: 1.2.2.16; previous revision: 1.2.2.15
done
Keywords: fixed1.8.1.7
verified fixed 1.8.1.7 using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.7pre) Gecko/2007091103 BonEcho/2.0.0.7pre and the steps to reproduce from comment #2.

After install of 2007091103 the addional entries in the Registry
and under Control Panel\Programs\Programs and Features are gone.

Adding verified keyword
You need to log in before you can comment on or make changes to this bug.