393149 - Some registry keys aren't removed under HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

I missed a short path condition in RegCleanMain when fixing bug 389244. Patch coming up

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: simple patch

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: Reg file to create extra reg entries for verification

After this lands...

Steps for verification (similar to bug 389244)

1. Open reg file to import the registry entries
2. Open regedit.exe and navigate to HKLM\Software\Mozilla
3. Note the multiple entries for Minefield
4. Run a latest nightly installer
5. Select custom during the install
6. Select C:\Yabba Dabba Do\Mozilla Firefox as the installation directory
7. After the install completes verify the additional registry entries noted in
step 3 are no longer present

Extra reg entry names
Minefield (3.0a5pre)
Minefield (3.0a6pre)

Comment 3

[Robert Strong (they/them - no direct email)]

Checked in to trunk
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh,v  <--  common.nsh
new revision: 1.21; previous revision: 1.20
done

Comment 4

[Robert Strong (they/them - no direct email)]

Tomcat, could you please verify this is fixed? Steps for verifying are in comment #2. You might want to verify bug 389244 at the same time. Thanks!

Comment 5

[Carsten Book [:Tomcat]]

(In reply to comment #4)
> Tomcat, could you please verify this is fixed? Steps for verifying are in
> comment #2. You might want to verify bug 389244 at the same time. Thanks!

Hi Rob, no problem. 
Also verified on vista with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007082205 Minefield/3.0a8pre and the steps to reproduce from this bug. After install of 2007082205 the addional entries in the Registry and under Control Panel\Programs\Programs and Features are gone.

- Verified

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 277676 [details] [diff] [review]
simple patch

This is a followup to bug 389244 for one more directory path comparison.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 277676 [details] [diff] [review]
simple patch

approved for 1.8.1.7, a=dveditz for release-drivers

Comment 8

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH for 1.8.1.7 (e.g. Firefox 2.0.0.7)

Checking in mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh,v  <--  common.nsh
new revision: 1.2.2.16; previous revision: 1.2.2.15
done

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: additional patch needed for branch differences

Comment 10

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.7 using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.7pre) Gecko/2007091103 BonEcho/2.0.0.7pre and the steps to reproduce from comment #2.

After install of 2007091103 the addional entries in the Registry
and under Control Panel\Programs\Programs and Features are gone.

Adding verified keyword