Closed Bug 393183 Opened 13 years ago Closed 12 years ago

Optstate not freed in ocspclnt.

Categories

(NSS :: Tools, defect, P3)

3.11.7
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.11.9

People

(Reporter: slavomir.katuscak+mozilla, Assigned: slavomir.katuscak+mozilla)

Details

Attachments

(1 file)

1.06 KB, patch
nelson
: review+
christophe.ravel.bugs
: superreview+
Details | Diff | Splinter Review
Memory Leak (mel):
Found leaked block of size 36 bytes at address 0x5e0600
At time of allocation, the call stack was:
    [1] PR_Malloc() at line 467 in "prmem.c"
    [2] PL_CreateLongOptState() at line 99 in "plgetopt.c"
    [3] PL_CreateOptState() at line 76 in "plgetopt.c"
    [4] main() at line 1027 in "ocspclnt.c"

Memory Leak (mel):
Found leaked block of size 20 bytes at address 0x5e05d0
At time of allocation, the call stack was:
    [1] calloc() at 0xe0954ab4
    [2] PR_Calloc() at line 475 in "prmem.c"
    [3] PL_CreateLongOptState() at line 92 in "plgetopt.c"
    [4] PL_CreateOptState() at line 76 in "plgetopt.c"
    [5] main() at line 1027 in "ocspclnt.c"

Allocated variable:
   1027     optstate = PL_CreateOptState (argc, argv, "AHLPR:S:V:d:l:pr:s:t:u:w:");
Assignee: nobody → slavomir.katuscak
Priority: -- → P3
Target Milestone: --- → 3.12
While you're at it, this change to ocspclnt.c will help, too:

     if (NSS_Shutdown () != SECSuccess) {
-       exit(1);
+       reval = 1;
     }
Target Milestone: 3.12 → 3.11.9
Attached patch Patch.Splinter Review
Attachment #288847 - Flags: superreview?(christophe.ravel.bugs)
Attachment #288847 - Flags: review?(nelson)
Attachment #288847 - Flags: review?(nelson) → review+
Version: trunk → 3.11.7
Attachment #288847 - Flags: superreview?(christophe.ravel.bugs) → superreview+
Trunk:
Checking in ocspclnt.c;
/cvsroot/mozilla/security/nss/cmd/ocspclnt/ocspclnt.c,v  <--  ocspclnt.c
new revision: 1.12; previous revision: 1.11
done

Branch:
Checking in ocspclnt.c;
/cvsroot/mozilla/security/nss/cmd/ocspclnt/ocspclnt.c,v  <--  ocspclnt.c
new revision: 1.7.28.2; previous revision: 1.7.28.1
done
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.