393253 - Buttons in 'places' panel must have 'id's to theme them.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alfred Kayser]

From bug 392976.
Can the buttons in the Places / editBookmark panel have id's, so can we can give them icons in our themes?

Thanks in advance, Alfred

Comment 1

[u88484]

This is the only button I found without an id http://mxr.mozilla.org/mozilla/source/browser/components/places/content/moveBookmarks.xul#80

Are there anymore...I'm thinking there might have been before some other patches landed or something?

Comment 2

[u88484]

Attachment: Patch

Adds an id for "newFolderButton"

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 282720 [details] [diff] [review]
Patch

there's a semicolon in the id value

Comment 4

[u88484]

Attachment: Patch 2.0

Oops, thanks dietrich

Comment 5

[Asaf Romano (gone)]

Comment on attachment 282729 [details] [diff] [review]
Patch 2.0

This bug was about the edit-item panel though, wasn't it?

Comment 6

[u88484]

Yeah I believe so but every xul file in http://mxr.mozilla.org/mozilla/source/browser/components/places/content/ the buttons have id's except the one in the patch.  I think the bug was filed before the last patch landing in bug 385266 so the buttons Alfred was talking about got id's.  The bug title was vague enough ('places' panel) that I think this bug can cover this patch.

Comment 7

[u88484]

Comment on attachment 282729 [details] [diff] [review]
Patch 2.0

Requesting 1.9 approval so themers can theme this button, low risk trivial patch.

Comment 8

[Reed Loden [:reed]]

Checking in browser/components/places/content/moveBookmarks.xul;
/cvsroot/mozilla/browser/components/places/content/moveBookmarks.xul,v  <--  moveBookmarks.xul
new revision: 1.5; previous revision: 1.4
done

Comment 9

[Alfred Kayser]

May be I should have been more clear:
The buttons in the places Panel that is shown when you click twice on the Star in the URLbar:
See http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.xul#103
103     <panel id="editBookmarkPanel" orient="vertical">
104       <vbox id="editBookmarkPanelContent" flex="1"/>
105       <hbox flex="1">
106         <spacer flex="1"/>
107         <button label="&editBookmark.delete.label;"
108                 oncommand="PlacesCommandHook.deleteButtonOnCommand();"/>
109         <button label="&editBookmark.done.label;"
110                 default="true"
111                 oncommand="PlacesCommandHook.doneButtonOnCommand();"/>
112       </hbox>
113     </panel>
Both buttons have here no id's. 

Comment 10

[u88484]

(In reply to comment #9)
> May be I should have been more clear:
> The buttons in the places Panel that is shown when you click twice on the Star
> in the URLbar:
> See http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.xul#103

Ahhh ok, sorry about that then.  Since this bug had a patch checked in and marked as fixed, I opened bug 398011.

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv