Closed
Bug 393269
Opened 18 years ago
Closed 17 years ago
js1_5/extensions/regress-381205.js FAIL browser only
Categories
(Core :: JavaScript Engine, defect, P3)
Tracking
()
VERIFIED
FIXED
People
(Reporter: bc, Assigned: mrbkap)
References
()
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
1.86 KB,
patch
|
jst
:
review+
jst
:
superreview+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
forked from bug 390948. test began failing 8/2-8/3. once bug 390948 was fixed, it showed this different error.
Flags: in-testsuite+
|
Reporter | |
Comment 1•18 years ago
|
||
fyi, error is invalid getter usage js1_5/extensions/regress-381205.js line 51
Flags: blocking1.9?
|
Assignee | |
Comment 2•18 years ago
|
||
I'm fairly confident that this is the same bug as bug 393268.
|
|
Assignee | |
Comment 3•18 years ago
|
||
I don't think we need to wrap anything in XOWs since we're same origin here, and all of the propagated getters should be scripted.
Assignee: crowder → mrbkap
Status: NEW → ASSIGNED
Attachment #283853 -
Flags: superreview?(jst)
Attachment #283853 -
Flags: review?(jst)
|
||
Updated•18 years ago
|
Attachment #283853 -
Flags: superreview?(jst)
Attachment #283853 -
Flags: superreview+
Attachment #283853 -
Flags: review?(jst)
Attachment #283853 -
Flags: review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #283853 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Priority: -- → P3
|
||
Updated•17 years ago
|
Attachment #283853 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•17 years ago
|
Flags: blocking1.9? → blocking1.9+
|
|
||
Updated•17 years ago
|
Flags: blocking1.9+ → blocking1.9-
Keywords: checkin-needed
|
|
Reporter | |
Comment 5•17 years ago
|
||
mrbkap, can I interrupt your holiday for a bit and ask you to check this in?
|
|
||
Comment 6•17 years ago
|
||
If this needs an update to be driven home/landed, I'd be glad to help.
|
|
Assignee | |
Comment 7•17 years ago
|
||
Sorry, the patch needs updating because I'd forgotten that SJOWs take this same codepath and need to be dealt with. New path is forthcoming (once I compile and test).
|
|
Assignee | |
Comment 8•17 years ago
|
||
Attachment #283853 -
Attachment is obsolete: true
Attachment #290480 -
Flags: superreview?(jst)
Attachment #290480 -
Flags: review?(jst)
|
|
||
Updated•17 years ago
|
Attachment #290480 -
Flags: superreview?(jst)
Attachment #290480 -
Flags: superreview+
Attachment #290480 -
Flags: review?(jst)
Attachment #290480 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #290480 -
Flags: approval1.9?
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
||
Comment 9•17 years ago
|
||
Comment on attachment 290480 [details] [diff] [review]
Updated to my comments
a=beltzner for drivers
Attachment #290480 -
Flags: approval1.9? → approval1.9+
|
||
Updated•17 years ago
|
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 10•17 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 11•17 years ago
|
||
This caused mochitest failures so I backed it out. I'll have to investigate later.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 12•17 years ago
|
||
(For my reference: the test that failed was the test for bug 255820)
Status: REOPENED → ASSIGNED
|
|
Assignee | |
Comment 13•17 years ago
|
||
This sucks a little. The problem is that, with this patch, we end up remembering the getter and setter for the characterSet property off of a document that's on an iframe. The test then calls document.open. In this case, we do not reuse the inner window and clear scope etc. Now, the getter and setter for doc.characterSet remember their prototype and scope. This means that the next time we try to get the characterSet property, we are unable to convert the JSObject into a wrapped native because the scopes don't match.
I think the "quick and dirty" fix for this bug would be to JS_ClearScope all XOWs for a particular document after a document.open.
|
|
Assignee | |
Comment 14•17 years ago
|
||
bug 399587 covers the last paragraph of comment 13.
Depends on: 399587
|
|
Assignee | |
Comment 15•17 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 16•17 years ago
|
||
/cvsroot/mozilla/js/tests/public-failures.txt,v <-- public-failures.txt
new revision: 1.16; previous revision: 1.15
|
|
Reporter | |
Comment 18•17 years ago
|
||
no longer verified due to back outs of bug 393267, bug 399587
/cvsroot/mozilla/js/tests/public-failures.txt,v <-- public-failures.txt
new revision: 1.18; previous revision: 1.17
|
|
Assignee | |
Comment 19•17 years ago
|
||
This is no longer in the tree (working on that, though).
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 20•17 years ago
|
||
Now re-checked-into trunk.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 21•17 years ago
|
||
verified fixed 1.9.0. I'll update public failures as part of the patch for bug 406196.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•