393330 - [FIX]"###!!! ASSERTION: comparing iterators over different lists" with large -moz-column-count and more

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: comparing iterators over different lists: 'mListLink == aOther.mListLink', file /Users/jruderman/trunk/mozilla/layout/generic/nsLineBox.h, line 684

Comment 1

[Eli Friedman]

This assertion doesn't indicate anything important... I'll try and take a look at some point, though.

Comment 2

[Jesse Ruderman]

Does it indicate the presence of a bug?  If not, it should be a warning or go away.

Comment 3

[Eli Friedman]

Well, yes, I think it does.  Not completely sure, though.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's probably indicating a bug in the line iterator code I just checked in to BuildTextRuns in nsTextFrameThebes.cpp.

Comment 5

[Eli Friedman]

No, it's asserting in nsBlockFrame::GetPrefWidth, which is my code.

Comment 6

[Boris Zbarsky [:bzbarsky]]

It's asserting in both, actually.  At least with a testcase over here.  ;)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Also fixes a bug with text-decoration in split blocks.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 288443 [details] [diff] [review]
Fix

well, I suppose end-game drivers should inspect this one

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed.