393446 - Buttons in the tagging and bookmarking UI are too narrow as of 2007082304. (Delete, Done, low, height; incorrectly; text; aligned; alignment)

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P4)

Description

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007082304 Minefield/3.0a8pre

They are approximately 2/5 less the normal height now. The text doesn't fit. WFM with 2007082204.

Comment 1

[[:Aleksej]]

Attachment: Screenshot of the bug.

Comment 2

[Atsushi Sakai]

Attachment: patch

This patch seems to fix this problem.
But I don't know whether this is the right thing because I don't understand why flex is there.

Comment 4

[[:Aleksej]]

Though it's become better in 2007082904…2007081004, they are still narrower than usual, and the text is not centered vertically.

Comment 5

[Hideo Oshima]

Attachment: Screen shot with a trunk build from 2007111104.

I can't reproduce with 2007111104-trunk build.
Is this fixed?

Comment 6

[[:Aleksej]]

Attachment: 2007111204 — still a bit too low

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre) Gecko/2007111204 Minefield/3.0b2pre
Still a bit too low, as in comment #4

Comment 7

[Mike Connor [:mconnor]]

Looks like just a polish issue at this point.

Comment 8

[[:Aleksej]]

Attachment: 2007111204 — still a bit too low — full screen shot

That screenshot makes me think that, too. Here’s a full screenshot. Still polish, but it does stand out.

Comment 11

[Mike Connor [:mconnor]]

Not going to continue to block on this.  If you disagree with this decision, please renominate with reasons why we can't ship with this in final

Comment 12

[Marco Bonardo [:mak]]

Attachment: screenshot FX3.1b3 on Ubuntu

Looks good to me actually

Comment 13

[Marco Bonardo [:mak]]

WFM per comment 12

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv