Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Hardcode language pack minVersion on the stable branch

VERIFIED FIXED

Status

()

Core
Localization
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Pike, Unassigned)

Tracking

({verified1.8.1.8})

Trunk
verified1.8.1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Created attachment 277976 [details] [diff] [review]
hardcode minVersion in browser-mail/locales/generic/install.rdf

On the stable branch, we should hardcode the minVersion of language packs, it makes using the branch for agile development of new localizations much more attractive. Plus, it's a dead simple and safe thing to do, as we know the minVersion anyway. For Firefox, I'm using 2.0.0.4 due to the change in the migration wizard, which should be good enough, for Thunderbird, I'm using 2.0 proper.

Without this fix, the minVersion gets set to 2.0.0.7pre, which makes it untestable on the latest release bits. That's just not right.

This patch is branch only.

Requesting review from Benjamin for l10n repack foo, CCing mconnor and mscott to give them a chance to veto this from a application point of view.
Attachment #277976 - Flags: review?(benjamin)
Attachment #277976 - Flags: review?(benjamin) → review+
(Reporter)

Comment 1

10 years ago
Comment on attachment 277976 [details] [diff] [review]
hardcode minVersion in browser-mail/locales/generic/install.rdf

Requesting branch approval. This is only affecting language packs generated from the stable branch, and sets the minVersion to something that's reasonable.

If we'd have to break compat down the 2.0.0.x stream, we'll adjust these again.
Attachment #277976 - Flags: approval1.8.1.7?
Comment on attachment 277976 [details] [diff] [review]
hardcode minVersion in browser-mail/locales/generic/install.rdf

approved for 1.8.1.7, a=dveditz for release-drivers
Attachment #277976 - Flags: approval1.8.1.7? → approval1.8.1.7+
(Reporter)

Comment 3

10 years ago
Landed on branch.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.1.7
Resolution: --- → FIXED
I guess there is no way to verify this on the branch, right?
(Reporter)

Comment 5

10 years ago
The .8pre language packs on http://l10n.mozilla.org/~buildslave/incubator/ work on stable releases, so this is verified.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.8 → verified1.8.1.8
You need to log in before you can comment on or make changes to this bug.