393546 - Star-icon needs a tooltip with a description of what it's doing when clicking on it

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Martijn Wargers (dead)]

New users won't know what that star-icon is, so they need at least a short description in the tooltip when hovering over it.

Comment 1

[Bill Gianopoulos [:WG9s]]

Well, this is kind of dependent on adding the recently starred items folder.  Currently, clicking on it does not really do anything that is useful so I don;t see how it would help to try to describe what it is doing currently in a tooltip.

Comment 3

[(not reading, please use [e-mail] instead)]

should the "star" button tooltip vary, depending on the state?

"bookmark this page" (when white)
"modify the bookmark for this page" (when yellow)

Comment 4

[[:Aleksej]]

(In reply to comment #3)
If it's implemented, it should.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

>"bookmark this page" (when white)
>"modify the bookmark for this page" (when yellow)

How about "Bookmark this page" and "Edit this bookmark."

Comment 6

[Bill Gianopoulos [:WG9s]]

I would certainly expect "Bookmark this page" to do what the "Bookmark this page" choice form the Bookmarks menu does.

It doesn't, therefore this is NOT the correct tooltip.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

>I would certainly expect "Bookmark this page" to do what the "Bookmark this
>page" choice form the Bookmarks menu does.

>It doesn't, therefore this is NOT the correct tooltip.

Both actions create a bookmark, and both actions are going to display the same UI.  The single difference is the default location the bookmark is placed in.  However given the other similarities, listing the single difference in the tooltip strikes me a needless increase in complexity.

Comment 8

[Dietrich Ayala (:dietrich)]

Attachment: fix

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 281848 [details] [diff] [review]
fix

needs more

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 281848 [details] [diff] [review]
fix

r=sspitzer, thank dietrich

Comment 11

[Dietrich Ayala (:dietrich)]

(In reply to comment #9)
> (From update of attachment 281848 [details] [diff] [review])
> needs more
> 

or not. i thought there may have been a scenario where the updateState() was not called, but i was wrong.

Comment 12

[Dietrich Ayala (:dietrich)]

Checking in browser/base/content/browser-places.js;
/cvsroot/mozilla/browser/base/content/browser-places.js,v  <--  browser-places.js
new revision: 1.52; previous revision: 1.51
done
Checking in browser/base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.374; previous revision: 1.373
done
Checking in browser/locales/en-US/chrome/browser/browser.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.properties,v  <--  browser.properties
new revision: 1.44; previous revision: 1.43
done

Comment 13

[Bob Uliss]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9) Gecko/2008051202 Firefox/3.0

Blue Solid Star on MAC OS tooltip reads Edit This Bookmark - same as the title of the Dialog Box that opens when the star is double clicked

Comment 14

[Paul Craciunoiu [:paulc]]

Verified on:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008060309 Firefox/3.0

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9) Gecko/2008053008 Firefox/3.0

Both hints (Edit/Add) are ok.

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv