Closed
Bug 393649
Opened 17 years ago
Closed 17 years ago
[FIX]"ASSERTION: assigning special sibling to other than first-in-flow!" with -moz-column, block-in-inline
Categories
(Core :: Layout, defect, P1)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(3 files)
|
356 bytes,
application/xhtml+xml
|
Details | |
|
280 bytes,
application/xhtml+xml
|
Details | |
|
1.19 KB,
patch
|
roc
:
review+
roc
:
superreview+
dbaron
:
approval1.9+
|
Details | Diff | Splinter Review |
Loading the testcase triggers:
###!!! ASSERTION: assigning special sibling to other than first-in-flow!: '!aFrame->GetPrevInFlow()', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 490
The final layout is consistent with the same DOM loaded as markup, but Find for the inserted text is broken when the bug is triggered. I took advantage of that by calling find() in order to make a reftest pair.
|
Reporter | |
Comment 1•17 years ago
|
||
In the reference, "XXX" is selected correctly, but in the testcase, it isn't (due to the bug that causes the assertion to fire, I'm guessing).
|
Assignee | |
Comment 2•17 years ago
|
||
Jesse, that is a _nice_ test!
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #278165 -
Flags: superreview?(roc)
Attachment #278165 -
Flags: review?(roc)
|
|
Assignee | |
Updated•17 years ago
|
OS: Mac OS X → All
Priority: -- → P1
Hardware: PC → All
Summary: "ASSERTION: assigning special sibling to other than first-in-flow!" with -moz-column, block-in-inline → [FIX]"ASSERTION: assigning special sibling to other than first-in-flow!" with -moz-column, block-in-inline
Target Milestone: --- → mozilla1.9 M8
Attachment #278165 -
Flags: superreview?(roc)
Attachment #278165 -
Flags: superreview+
Attachment #278165 -
Flags: review?(roc)
Attachment #278165 -
Flags: review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Comment on attachment 278165 [details] [diff] [review]
Fix
Very safe regression fix.
Attachment #278165 -
Flags: approval1.9?
Comment on attachment 278165 [details] [diff] [review]
Fix
a1.9=dbaron
Attachment #278165 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Fixed. Test checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
|
Reporter | |
Comment 6•17 years ago
|
||
The tests were checked in as .html files. I think they should have been checked in as .xhtml, since they use div inside span (the HTML parser doesn't like that).
|
|
Assignee | |
Comment 7•17 years ago
|
||
Uh... no. The HTML parser allows <div> inside <span> just fine. I tested with the testcases I checked in before and after the patch, of course.
|
|
Reporter | |
Comment 8•17 years ago
|
||
Oh, interesting. It does strange things with <div> inside <b>, but it leaves <div> inside <span> alone.
|
|
Assignee | |
Comment 9•17 years ago
|
||
Yep.
You need to log in
before you can comment on or make changes to this bug.
Description
•