393661 - "ASSERTION: aFrame not the result of GetPrimaryFrameFor()?" with floating :first-letter

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: aFrame not the result of GetPrimaryFrameFor()?: 'aFrame == aFrame->GetFirstContinuation()', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 10940

Comment 1

[Mats Palmgren (inactive)]

Regression from bug 390425.  The frame tree looks the same as before that
bug though, so it seems we have always had this problem...

Comment 2

[Mats Palmgren (inactive)]

Attachment: Frame tree

Comment 3

[Mats Palmgren (inactive)]

Attachment: WIP

The problem seems to be that nsCSSFrameConstructor::FindPrimaryFrameFor()
can't find the first text frame since it's wrapped in an out-of-flow.
I guess we could detect this special case, if this is the frame we want to
be the primary frame?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, we had this issue all along; I just added the assertion in that bug.

I think FindPrimaryFrameFor should walk through placeholders when recursing into kids.  That would fix both this case and out-of-flow generated content when we start to support it.

Comment 5

[Boris Zbarsky [:bzbarsky]]

It looks like bug 403425 was basically about this, as was bug 403245.

Fixed by checkin for bug 405186 (implements what I suggest in comment 4).

Comment 6

[Jesse Ruderman]

Crashtest checked in.