39368 - Enable async reflow processing during document load

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[Nisheeth Ranjan]

The following things need to happen in layout:

1) Differentiate between reflow events generated during document load and after 
document load.
2) Create an object that exposes the nsIRequest interface.  Add the object to 
the load group at the start of layout and remove it once all the "during doc 
load" reflow events have been processed.
3) Fix up the perf metrics code.

The following things need to happen in necko:
1) Change nsILoadGroup so that requests can get added and removed rather than 
channels.
2) Fix up the XUL cache code.

We'll work on this post beta 2.

Comment 1

[Nisheeth Ranjan]

Accepting bug and setting target milestone to M17...

Comment 2

[Nisheeth Ranjan]

*** Bug 24822 has been marked as a duplicate of this bug. ***

Comment 3

[gabriel]

Shouldn't this be for *all* OS ?

Comment 4

[Nisheeth Ranjan]

Changing OS to All and marking nsbeta3...

Comment 5

[ekrock's old account (dead)]

Marking perf.

Comment 6

[Peter Trudelle]

nsbeta3+, to the extent that it will increased perceived speed/responsiveness, 
especially on Mac.

Comment 7

[Nisheeth Ranjan]

Marking P1..

Comment 8

[Phil Peterson]

PDT downgrading to P2 and adding [PDTP2] to status whiteboard. We'd really like
to have this.

Comment 9

[Phil Peterson]

PDT wondering if this is the same bug as blocking the throbber/progress while
downloading a page. Still agree P2.

Comment 10

[Nisheeth Ranjan]

I have this fixed and will check it in tonight protected by a pref that is
disabled by default.  I'm not enabling the pref by default because I did not see
much difference in perceived performance on my windows box.  Mike and I will 
test
this on the Mac on (slow machine, slow network), (slow machine, fast network),
(fast machine, slow network), (fast machine, fast network) configurations.  If
this makes a significant difference in any configuration, we can enable the pref
by default.  Right now, the only data point we have is that this fix does not do
much on a fast machine, fast network configuration on Windows.

Comment 11

[Nisheeth Ranjan]

*** Bug 50634 has been marked as a duplicate of this bug. ***

Comment 12

[Nisheeth Ranjan]

I've turned on async reflow during doc load by default. It can be turned off by
setting the "layout.reflow.async.duringDocLoad" pref to false in prefs.js.

Marking bug fixed.

Comment 13

[Chris Petersen]

Marking verified per last comments.