Sunbird installer includes everything under the optional directory

VERIFIED FIXED in 0.7

Status

Calendar
Sunbird Only
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
x86
Windows Vista

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 278226 [details] [diff] [review]
patch - remove comment that causes this bug

I just noticed Sunbird has more than just the optional components under the optional directory in the self extracting archive for the installer.
Attachment #278226 - Flags: review?(mschroeder)
Comment on attachment 278226 [details] [diff] [review]
patch - remove comment that causes this bug

If you remove it from the Makefile, you can also remove the already commented out [adt] section from packages-static.

r=mschroeder with additional removal in packages-static

Stefan, please also have a look at the patch. You have more experience with the installer.
Attachment #278226 - Flags: review?(ssitter)
Attachment #278226 - Flags: review?(mschroeder)
Attachment #278226 - Flags: review+

Comment 2

10 years ago
Comment on attachment 278226 [details] [diff] [review]
patch - remove comment that causes this bug

r=ssitter
Attachment #278226 - Flags: review?(ssitter) → review+
Created attachment 278442 [details] [diff] [review]
patch updated to comments

Carrying forward r+
Attachment #278226 - Attachment is obsolete: true
Attachment #278442 - Flags: review+
Stefan, do you want this on MOZILLA_1_8_BRANCH as well? I know Sunbird tried to keep these in sync as much as possible.

Comment 5

10 years ago
Yes, please checkin to MOZILLA_1_8_BRANCH and HEAD.
Checked in to MOZILLA_1_8_BRANCH

Checking in mozilla/calendar/installer/Makefile.in;
/cvsroot/mozilla/calendar/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.3.4.9; previous revision: 1.3.4.8
done
Checking in mozilla/calendar/installer/windows/packages-static;
/cvsroot/mozilla/calendar/installer/windows/packages-static,v  <--  packages-static
new revision: 1.10.2.32; previous revision: 1.10.2.31
done

Checked in to trunk

Checking in mozilla/calendar/installer/Makefile.in;
/cvsroot/mozilla/calendar/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.12; previous revision: 1.11
done
Checking in mozilla/calendar/installer/windows/packages-static;
/cvsroot/mozilla/calendar/installer/windows/packages-static,v  <--  packages-static
new revision: 1.46; previous revision: 1.45
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 7

10 years ago
Verified. The win32 installer for Sunbird 0.7pre (2007082804) contains only the Talkback files in the optional directory.
Status: RESOLVED → VERIFIED

Updated

10 years ago
Target Milestone: --- → 0.7
You need to log in before you can comment on or make changes to this bug.