393698 - Sunbird installer includes everything under the optional directory

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Robert Strong (they/them - no direct email)]

Attachment: patch - remove comment that causes this bug

I just noticed Sunbird has more than just the optional components under the optional directory in the self extracting archive for the installer.

Comment 1

[Martin Schröder [:mschroeder]]

Comment on attachment 278226 [details] [diff] [review]
patch - remove comment that causes this bug

If you remove it from the Makefile, you can also remove the already commented out [adt] section from packages-static.

r=mschroeder with additional removal in packages-static

Stefan, please also have a look at the patch. You have more experience with the installer.

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 278226 [details] [diff] [review]
patch - remove comment that causes this bug

r=ssitter

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch updated to comments

Carrying forward r+

Comment 4

[Robert Strong (they/them - no direct email)]

Stefan, do you want this on MOZILLA_1_8_BRANCH as well? I know Sunbird tried to keep these in sync as much as possible.

Comment 5

[Stefan Sitter [:ssitter]]

Yes, please checkin to MOZILLA_1_8_BRANCH and HEAD.

Comment 6

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH

Checking in mozilla/calendar/installer/Makefile.in;
/cvsroot/mozilla/calendar/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.3.4.9; previous revision: 1.3.4.8
done
Checking in mozilla/calendar/installer/windows/packages-static;
/cvsroot/mozilla/calendar/installer/windows/packages-static,v  <--  packages-static
new revision: 1.10.2.32; previous revision: 1.10.2.31
done

Checked in to trunk

Checking in mozilla/calendar/installer/Makefile.in;
/cvsroot/mozilla/calendar/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.12; previous revision: 1.11
done
Checking in mozilla/calendar/installer/windows/packages-static;
/cvsroot/mozilla/calendar/installer/windows/packages-static,v  <--  packages-static
new revision: 1.46; previous revision: 1.45
done

Comment 7

[Stefan Sitter [:ssitter]]

Verified. The win32 installer for Sunbird 0.7pre (2007082804) contains only the Talkback files in the optional directory.