393737 - GTK buttons should have a "default button" style if its the default button

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Michael Ventnor]

Comment 1

[Michael Ventnor]

Attachment: Patch

Whoops, submitted this bug accidentally and too early.

On other platforms we support giving default buttons (the button activated when you hit Return, eg. the OK button in dialogs) a special styling. On GTK, there is commented-out code for this, but the code is wrong.

We can apply the GTK theme's "default button" style by setting one flag, so I imagine this patch is trivial enough for 1.9.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+    if (state->isDefault)
+        GTK_WIDGET_UNSET_FLAGS(widget, GTK_HAS_DEFAULT);

Could this be unconditional? I'm assuming GTK_WIDGET_UNSET_FLAGS is very cheap.

Comment 3

[Michael Ventnor]

Would it be cheaper than an if() statement though? I only put it there because I'm  not sure whether that macro will cause problems if the flag isn't set anyway.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It doesn't have to be cheaper than an if() statement, it just has to be similar ... then removing one line of code would be a good thing.

> I only put it there because I'm  not sure whether that macro will cause
> problems if the flag isn't set anyway.

It won't:

#define GTK_WIDGET_UNSET_FLAGS(wid,flag)  G_STMT_START{ (GTK_WIDGET_FLAGS (wid) &= ~(flag)); }G_STMT_END

Comment 5

[Michael Ventnor]

Attachment: Patch 2

Comment 6

[Nickolay_Ponomarev]

mozilla/widget/src/gtk2/gtk2drawing.c         1.29
mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp  1.102