393897 - IA2 methods returning S_FALSE on success

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Certain methods like get_textAtOffset() are returning S_FALSE, when the caller is expecting S_OK.

http://lxr.mozilla.org/seamonkey/source/accessible/src/msaa/CAccessibleText.cpp#313

It must be lines like this causing the problem:
return ::SysReAllocStringLen(aText, text.get(), text.Length());

We need to take a look at the return values for ::SysReAllocStringLen(). It might be be that we need to explicitly return S_OK;

Comment 1

[alexander :surkov (:asurkov)]

It looks I was confused by mobile version of SysReAllocStringLen (see http://msdn2.microsoft.com/en-us/library/Aa910803.aspx) that returns HRESULT. The version we use is http://msdn2.microsoft.com/en-us/library/ms221533.aspx where TRUE means successful result. But if I get right boolean(S_FALSE) is TRUE. Correct? How can I test it?

Comment 2

[Aaron Leventhal]

> boolean(S_FALSE) is TRUE.
What do you mean?

Can you do:

success = ::SysReAllocStringLen(...);
return success ? S_OK: E_FAIL;

You should be able to test it just by using the API in any small test-app, or a printf before you return to say what you are returning.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> > boolean(S_FALSE) is TRUE.
> What do you mean?

I mean S_OK == 0 == PR_FALSE
E_FAIL == 1 == PR_TRUE

Comment 5

[alexander :surkov (:asurkov)]

checked in