Remove nsIDownloadProgressListener::onStatusChange and nsIDownloadProgressListener::onLocationChange

RESOLVED FIXED in mozilla1.9beta3

Status

()

Toolkit
Downloads API
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: sdwilsh, Assigned: graememcc)

Tracking

Trunk
mozilla1.9beta3
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
Spun off from Bug 289540 Comment 21.  These are unused and should be removed.
(Reporter)

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [good first bug]
(Assignee)

Comment 1

10 years ago
Created attachment 294698 [details] [diff] [review]
v0.1
Attachment #294698 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #294698 - Flags: review? → review-
(Assignee)

Updated

10 years ago
Attachment #294698 - Flags: review- → review?(comrade693+bmo)
(Reporter)

Comment 2

10 years ago
Comment on attachment 294698 [details] [diff] [review]
v0.1

Almost!  You need to generate a new uuid for the interface since methods are being removed (http://developer.mozilla.org/en/docs/Generating_GUIDs).

Also, there are some test files that need the extra methods removed:
http://tinyurl.com/2nmvlq
Attachment #294698 - Flags: review?(comrade693+bmo) → review-
(Assignee)

Comment 3

10 years ago
Created attachment 294726 [details] [diff] [review]
v0.2

Changes as per comment 2
Attachment #294698 - Attachment is obsolete: true
Attachment #294726 - Flags: review?(comrade693+bmo)
(Reporter)

Comment 4

10 years ago
Comment on attachment 294726 [details] [diff] [review]
v0.2

r=sdwilsh
Attachment #294726 - Flags: review?(comrade693+bmo)
Attachment #294726 - Flags: review+
Attachment #294726 - Flags: approval1.9?
Comment on attachment 294726 [details] [diff] [review]
v0.2

a=beltzner for 1.9
Attachment #294726 - Flags: approval1.9? → approval1.9+
(Reporter)

Comment 6

10 years ago
Thanks for the patch!
Assignee: nobody → graememcc_firefox
Keywords: checkin-needed
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
Thanks for the patch!

Checking in toolkit/components/downloads/public/nsIDownloadProgressListener.idl;
/cvsroot/mozilla/toolkit/components/downloads/public/nsIDownloadProgressListener.idl,v  <--  nsIDownloadProgressListener.idl
new revision: 1.6; previous revision: 1.5
done
Checking in toolkit/components/downloads/test/unit/head_download_manager.js;
/cvsroot/mozilla/toolkit/components/downloads/test/unit/head_download_manager.js,v  <--  head_download_manager.js
new revision: 1.8; previous revision: 1.7
done
Checking in toolkit/components/downloads/test/unit/test_bug_395092.js;
/cvsroot/mozilla/toolkit/components/downloads/test/unit/test_bug_395092.js,v  <--  test_bug_395092.js
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/downloads/test/unit/test_bug_401430.js;
/cvsroot/mozilla/toolkit/components/downloads/test/unit/test_bug_401430.js,v  <--  test_bug_401430.js
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/downloads/test/unit/test_download_manager.js;
/cvsroot/mozilla/toolkit/components/downloads/test/unit/test_download_manager.js,v  <--  test_download_manager.js
new revision: 1.15; previous revision: 1.14
done
Checking in toolkit/components/downloads/test/unit/test_resume.js;
/cvsroot/mozilla/toolkit/components/downloads/test/unit/test_resume.js,v  <--  test_resume.js
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/mozapps/downloads/content/DownloadProgressListener.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/DownloadProgressListener.js,v  <--  DownloadProgressListener.js
new revision: 1.36; previous revision: 1.35
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.