move source tarball creation into bootstrap

RESOLVED FIXED

Status

defect
P3
normal
RESOLVED FIXED
12 years ago
6 years ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: waiting on review)

Attachments

(4 attachments, 1 obsolete attachment)

Bootstrap currently calls a script called e.g. "firefox-src-tarball-nobuild.sh" in the private repo - http://mxr.mozilla.org/mozilla/source/tools/release/Bootstrap/Step/Source.pm#32

We should just move that script's functionality into Bootstrap::Step::Source, so it's more directly configurable. All it really does is a CVS checkout using a tag, and tar -jcf the results.
Priority: -- → P3
Attachment #280099 - Attachment mime type: application/octet-stream → text/plain
Still testing, but I think that this should do the trick. I'm going to diff this against a shipped source tarball to make sure that nothing is missing.
Assignee: build → rhelmer
Status: NEW → ASSIGNED
Attachment #283136 - Flags: review?(preed)
Comment on attachment 283136 [details] [diff] [review]
move source tarball creation into bootstrap

>Index: Bootstrap/Step/Source.pm
>===================================================================
>RCS file: /cvsroot/mozilla/tools/release/Bootstrap/Step/Source.pm,v
>retrieving revision 1.8
>diff -u -r1.8 Source.pm
>--- Bootstrap/Step/Source.pm	2 Oct 2007 03:00:19 -0000	1.8
>+++ Bootstrap/Step/Source.pm	2 Oct 2007 05:40:01 -0000
>@@ -106,4 +129,18 @@
>     );
> }
> 
>+# Change the CVS/Root file to be the anonymous CVS Root
>+sub CvsChrootCallback {
>+     my $config = new Bootstrap::Config();
>+     my $anonCvsroot = $config->Get(var => 'anonCvsroot');
>+
>+     my $dirent = $File::Find::name;
>+     print "dirent: $dirent\n";

Er, pretend like this print I put in for debugging is not there pls :)
A diff of the released source tarball and one generated by this script showed that .mozconfig.out and .mozconfig.mk were left over, which the old script removed.

This patch is the same as the last, except it unlinks the above files, and removes a print statement (debugging).
Attachment #283136 - Attachment is obsolete: true
Attachment #283141 - Flags: review?(preed)
Attachment #283136 - Flags: review?(preed)
Whiteboard: waiting on review
I've just talked with preed. He's working on bug#396281, so can you reassign this pending patch review to me instead? I can review it immediately.
Attachment #283141 - Flags: review?(preed) → review?(joduinn)
Comment on attachment 283141 [details] [diff] [review]
move source tarball creation into bootstrap, take 2

reviewed already earlier this morning, and again just now. 

Looks good to me.
Attachment #283141 - Flags: review?(joduinn) → review+
(In reply to comment #5)
> I've just talked with preed. He's working on bug#396281, so can you reassign
> this pending patch review to me instead? I can review it immediately.

For the record, I told rhelmer I'd review this by close of business today, 3rd October.
Same as attachment 283141 [details] [diff] [review], plus added anonCvsroot to bootstrap.cfg.example:

Checking in bootstrap.cfg.example;
/cvsroot/mozilla/tools/release/bootstrap.cfg.example,v  <--  bootstrap.cfg.example
new revision: 1.7; previous revision: 1.6
done
Checking in Bootstrap/Step/Source.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Source.pm,v  <--  Source.pm
new revision: 1.9; previous revision: 1.8
done
(In reply to comment #7)
> (In reply to comment #5)
> > I've just talked with preed. He's working on bug#396281, so can you reassign
> > this pending patch review to me instead? I can review it immediately.
> 
> For the record, I told rhelmer I'd review this by close of business today, 3rd
> October.


This doesn't make sense given the comment you quoted. Did you two discuss this or not?

Please take this discussion elsewhere.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Sorry, I should not have changed these to be different log files; the Verify script depends on them, and there's no point to having different ones.
Attachment #283474 - Flags: review?(joduinn)
Attachment #283474 - Flags: review?(joduinn) → review+
Attachment #283474 - Attachment description: just use source.log for all logs → [checked in]just use source.log for all logs
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.