394052 - Leaking five foo.xml documents running one or more of the mochitests using property_database.js

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Jeff Walden [:Waldo]]

When I run the mochitests with leak-gauge.pl logging, I leak five documents for foo.xml.  I don't know yet which test(s) actually cause(s) these leaks.

Comment 1

[Eli Friedman]

Attachment: Patch

This fixes the leak for remote XBL; failed loads for XBL from file:// URLs still cause a leak, but this should fix the leak showing up with mochitests.

Not sure if this is the best way to go about fixing this, but the relevant code is very messy.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Is this basically the same as bug 324465?

Comment 3

[Eli Friedman]

Yes, looks like it.  I'll set blocking since the patch is here.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Why are the nsXBLBindingRequest::Destroy in nsXBLStreamListener::Load and nsXBLStreamListener::OnStopRequest no longer needed?

Comment 5

[Jeff Walden [:Waldo]]

In my testing this is currently the only window/document/docshell leak in Mochitests.  We should push on this and get it fixed before some new leak shows up that prevents leak-gauge testing from being added to runtests.pl.

As for the Destroys not being necessary, I think that's just relying on Load/OnStopRequest not firing multiple times, I think (based on reading the patch and vague memories of when the patch was written).  I remember a question about whether OnStopRequest fired twice, with the answer being only for multipart/alternative (?), which probably wouldn't work already anyway.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Eli: Still waiting for a reply from you to the question in comment 4

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 278710 [details] [diff] [review]
Patch

This leak seems unlikely to happen for normal web pages, so lets wait with this until after beta.