Closed Bug 394117 Opened 13 years ago Closed 13 years ago

Warnings when accessible relations queried

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

These warnings occur:
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file c:/moz/mozilla/accessible
/src/base/nsAccessible.cpp, line 2800
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file c:/moz/mozilla/accessible
/src/base/nsAccessible.cpp, line 2764
I can rev the IID if everyone things we need to for the FIRST_RELATION and LAST_RELATION consts, but it seems unncecessary.
Attachment #278725 - Flags: review?(surkov.alexander)
Comment on attachment 278725 [details] [diff] [review]
1) Don't ask for relation #0, there is none, 2) Don't bother checking failure code since we already check the returned |accessible| -- sometimes the failure code just means "not implemented"

r=me
Attachment #278725 - Flags: review?(surkov.alexander) → review+
Attachment #278725 - Flags: review?
Attachment #278725 - Flags: review? → approval1.9?
Attachment #278725 - Flags: approval1.9? → approval1.9+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.