"ASSERTION: post-reflow queues not empty" with xul:listboxbody and xul:text

RESOLVED FIXED

Status

()

Core
XUL
--
major
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Jesse Ruderman, Assigned: smaug)

Tracking

(Blocks: 1 bug, 5 keywords)

Trunk
x86
Mac OS X
assertion, fixed1.8.1.8, mlk, qawanted, testcase
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.1.8 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
Created attachment 278729 [details]
testcase (reload to see the assertions)

*Reloading* the testcase triggers:

###!!! ASSERTION: post-reflow queues not empty.  This means we're leaking: 'mFirstCallbackEventRequest == nsnull && mLastCallbackEventRequest == nsnull', file /Users/jruderman/trunk/mozilla/layout/base/nsPresShell.cpp, line 1402

###!!! ASSERTION: Some objects allocated with AllocateFrame were not freed: 'mFrameCount == 0', file /Users/jruderman/trunk/mozilla/layout/base/nsPresShell.cpp, line 673

I'm marking this bug as major because being able to test for the "Some objects allocated with AllocateFrame were not freed" assertion is important for detecting a class of memory safety bugs.
Flags: blocking1.9?
(Assignee)

Updated

10 years ago
Assignee: nobody → Olli.Pettay
(Assignee)

Comment 1

10 years ago
Created attachment 278751 [details] [diff] [review]
proposed patch

Sorry, my mistake.
Better to post the callback when reflowing, then it gets called always and there
is no need to cancel it.
Attachment #278751 - Flags: superreview?(roc)
Attachment #278751 - Flags: review?(roc)
(Assignee)

Updated

10 years ago
Blocks: 387033
Attachment #278751 - Flags: superreview?(roc)
Attachment #278751 - Flags: superreview+
Attachment #278751 - Flags: review?(roc)
Attachment #278751 - Flags: review+
Attachment #278751 - Flags: approval1.9+
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Depends on: 368573
Flags: in-testsuite?
qawanted: verify this doesn't regress on the 1.8 branch after bug 387033 lands
Flags: blocking1.8.1.8+
Keywords: qawanted
(Assignee)

Updated

10 years ago
Keywords: fixed1.8.1.8
I can't really verify this on the 1.8 branch.
My debug 1.8 branch builds are from before this patch was checked in, but I don't get any assertion when reloading the testcase with those.
Flags: blocking1.9?
(Reporter)

Comment 4

10 years ago
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+

Updated

9 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.