394128 - Add toolkit version to update data returned.

Status: RESOLVED WONTFIX

(AUS Graveyard :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

Bug 299716 landed to support extension compatibility with versions of the toolkit. To support displaying incompatible add-ons that use a toolkit version for compatibility we need the app update information to include the version of the toolkit in the same way that it provides the app version.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

As I understand this (and I might be wrong!) without fixing this issue a user might be erroneously told that an add-on update will be compatible when, in fact, it won't. So that user might update their add-on, and then still see the "add-on incompatible" message.

I'm OK with not blocking if that understanding is correct. If this can lead to busted add-ons, though, or potentially incompatible add-ons being loaded, then please re-nominate.

Comment 2

[Dave Townsend [:mossop]]

No it is the opposite, the user might not be told that some of their add-ons will be disabled with the update re-requesting on this basis, but I don't really think it should be blocking. As far as I know we can potentially add this after the Firefox release, there is no code change to Firefox that I know of.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

I agree, I don't think this blocks the release of Firefox 3.

morgamic/clouserw: how should we be marking these web-tools bugs which have a significant effect on the product? In this case, it's not a blocker, but is there any way of flagging it as really important?

Comment 4

[Robert Strong (they/them - no direct email)]

Should be fixed when bug 459972 is fixed

Comment 5

[Robert Strong (they/them - no direct email)]

No longer needed.