394170 - Add external scripts to Links tab of the new Page Info dialog

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Sander]

Quoting from IRC:

<Sander> Anyone know if the new page info dialog (bug 379183) will retain a tree based privacy section? I find that panel invaluable, especially for seeing which external javascript files are being loaded (since that often happens dynamically through a huge mess of scripts calling other scripts).
<KaiRo> Sander: oh, that's p3p UI and will be killed along with P3P
<KaiRo> Sander: an own tab for that doesn't make sense, IMHO... it might be an idea to add external scripts to the Links tab though
<KaiRo> Sander: could you file a bug on that and make it dependent on the general pageinfo one?
<KaiRo> Sander: given that we list stylesheets etc. there, I guess it makes sense, after all it's some kind of link as well
<NeilAway> Sander: in theory that part could be rewritten in JS, but someone would have to do that work...

Comment 1

[Daniel Brooks [:db48x]]

Attachment: 394170-1.diff

Comment 2

[Robert Kaiser]

Comment on attachment 290926 [details] [diff] [review]
394170-1.diff

>Index: suite/browser/pageinfo/pageInfo.js
>===================================================================
>+  var strNames = ["unknown", "notSet", "mediaImg", "mediaBGImg", "mediaApplet",
>+                  "mediaObject", "mediaEmbed", "mediaLink", "mediaInput",
>+                  "formTitle", "formUntitled", "formDefaultTarget",
>+                  "formChecked", "formUnchecked", "formPassword", "linkAnchor",
>+                  "linkArea", "linkSubmission", "linkSubmit", "linkRel",
>+                  "linkStylesheet", "linkRev", "linkX", "linkScript",
>+                  "linkScriptInline", "yes"];
>+  strNames.forEach(function(n) { gStrings[n] = gBundle.getString(n); });

From what I see, you forgot to attach the part of the patch that adds "linkScript", "linkScriptInline" to the .properties file. I can't review as my complete page info dialog is broken atm, probably due to that omission ;-)

Comment 3

[Daniel Brooks [:db48x]]

Attachment: 394170-2.diff

My fault, I must have forgotten to include the locales directory in the diff

Comment 4

[Robert Kaiser]

Comment on attachment 291685 [details] [diff] [review]
394170-2.diff

Yes, this looks and works fine now, thanks. r=me

Comment 5

[Daniel Brooks [:db48x]]

checked in.

Comment 6

[Sander]

Looks good. Thanks! (Now if only bug 76170 got fixed so I can sort all scripts together, it'd be sheer perfection.) :)

Comment 7

[[e-mail]]

(In reply to Sander from comment #6)
> Looks good. Thanks! (Now if only bug 76170 got fixed so I can sort all
> scripts together, it'd be sheer perfection.) :)

Ironically it was bug 76170 that exposed a bug in this patch...