394174 - Attendees list is blank in new event summary dialog

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Omar Bajraszewski]

STEPS TO REPRODUCE:
===================

- Subscribe to http://sd-calendar.staroffice.de/
- Mark the calendar as a read only
- double click on event with added attendees

RESULT:
=======

- Attendees list is blank in new event summary dialog

EXPECTED RESULT:
================

- Attendees are shown in new event summary dialog

REPRODUCIBLE:
=============

- always

Comment 1

[Omar Bajraszewski]

Event summary dialog is a new enhancement and doesn't work as expected---> requesting blocking 0.7

Comment 2

[Stefan Sitter [:ssitter]]

I can confirm with an event in read-only storage calendar. The Console shows:

  Error: organizer is not defined
  Source File: chrome://calendar/content/calendar-summary-dialog.js
  Line: 264

Comment 3

[Daniel Boelzle [:dbo]]

need to be resolved

Comment 4

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

Inadvertent typo. Admittedly, I'm really missing a decent compiler that bails out under these circumstances. Anyway, I also took the liberty to correct the wrong handling of the 'mailto' prefix which I came across.

Comment 5

[Daniel Boelzle [:dbo]]

Comment on attachment 279074 [details] [diff] [review]
patch v1

>+            } else {
>+                email = email;
remove that else-block

>+                    if (email && email.length) {
>+                        if (re.test(email)) {
>+                            email = RegExp.$1;
>+                        } else {
>+                            email = email;
>+                        }
>                     }
just
if (email && re.test(email)) {
    email = RegExp.$1;
}
here

btw: RegExp.$1 is deprecated, use exec()

r=dbo

Comment 6

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 7

[Omar Bajraszewski]

Verified with lightning 2007090504

Comment 8

[Omar Bajraszewski]

Verified with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.7pre) Gecko/20070906 Calendar/0.7pre