394191 - [Proto] Title of Recurrence dialog is "Edit item"

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.7pre) Gecko/20070829 Calendar/0.7pre

Similar to Bug 362936. The dialog title of the recurrence dialog is "Edit item".

Steps To Reproduce:
1. Start Sunbird with fresh profile
2. Create new repeating event. Select Repeat -> Custom...

Actual Results:
Dialog title of the recurrence dialog is "Edit item".

Expected Results:
Dialog title is more descriptive.

Christian - is this on purpose? Is there already a proposal somewhere? How about "Custom Repetition" or "Custom Recurrence" or "Edit Recurrence" or ...

Comment 1

[Christian Jansen]

(In reply to comment #0)
[...]
> Christian - is this on purpose? Is there already a proposal somewhere? How
> about "Custom Repetition" or "Custom Recurrence" or "Edit Recurrence" or ...
> 

No, this is not on purpose. There is a proposal, but I'm not sure if it is better.
http://wiki.mozilla.org/Calendar:SMB_Event_Dialog_-_Recurrence_Dialog#The_Recurrence_Dialog

I suggested "Event Recurrence". Has anyone a better suggestion?

Comment 2

[Stefan Sitter [:ssitter]]

The recurrence dialog is also used for tasks therefore I think "Event Recurrence" is not suitable. Sunbird 0.5 used the title "Edit Recurrence". Or maybe just "Recurrence"?

Comment 3

[Christian Jansen]

"Edit Recurrence" sounds good to me. I'll update the wiki page.

Comment 4

[Stefan Sitter [:ssitter]]

Attachment: rev0 - change dialog title to "Edit Recurrence"

I also addressed the ID issues mentioned in Bug 362936 Comment #4 and Bug 362936 Comment #6.

Comment 5

[Michael Büttner (no reviews TFN)]

Comment on attachment 279093 [details] [diff] [review]
rev0 - change dialog title to "Edit Recurrence"

Works as advertised. Thanks for the patch, Stefan. r=mickey.

Comment 6

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 7

[Omar Bajraszewski]

verified with lightning 2007090103 and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7pre) Gecko/20070901 Calendar/0.7pre

Comment 8

[Omar Bajraszewski]

Verified with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.7pre) Gecko/20070906 Calendar/0.7pre