394204 - Switch popup blocking to CHPermissionManager

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Stuart Morgan]

Attachment: switch

I thought I got everything but prefs (which are currently blocked) off of nsIPermisionManager, but apparently not.

Comment 1

[Nick Kreeger]

Comment on attachment 278818 [details] [diff] [review]
switch

Looks good to me. Sorry, this got lost on my radar.

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 278818 [details] [diff] [review]
switch

-- (void)whitelistPopupsFromURL:(NSString*)inURL
-{
-  nsCOMPtr<nsIURI> uri;

rather than removing it, why not have it be consistent with the blacklist method, which also just calls through the the CHPermissions stuff? Why have the caller make the raw call in one case but not the other? Just seems more consistent.

sr=pink regardless.

Comment 3

[Stuart Morgan]

Blacklist is only still there because it's a public method, due to somewhat legacy architecture of the popup blocker. I plan to improve the situation further, but removing the unnecessary private method for seemed like more of a win given that the two methods were already asymmetrical.

Landed on trunk and MOZILLA_1_8_BRANCH.