394228 - Downloading files can randomly fail.

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007082902 Minefield/3.0a8pre ID:2007082902

1. New profile, start firefox
2. Open ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk
3. Right click on firefox-3.0a8pre.en-US.mac.complete.mar and choose Save Link As. Choose a dir, and hit Save.
4. Right click on firefox-3.0a8pre.en-US.mac.dmg and choose Save Link As. Keep the current dir, and hit Save.

Expected:
Both files download

Actual:
First file downloads, second file does not download (stays in "Starting..." status, but never starts). If you cancel this second file and then retry the download, it starts fine.

Error console reports:

Error: this.recentWindow.QueryInteface is not a function
Source File: file:///C:/Documents%20and%20Settings/Ste/Desktop/Firefox%20Trunk%20(PLACES)/firefox/components/nsDownloadManagerUI.js
Line: 103

Error: uncaught exception: [Exception... "'[JavaScript Error: "this.recentWindow.QueryInteface is not a function" {file: "file:///C:/Documents%20and%20Settings/Ste/Desktop/Firefox%20Trunk%20(PLACES)/firefox/components/nsDownloadManagerUI.js" line: 103}]' when calling method: [nsIDownloadManagerUI::getAttention]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/contentAreaUtils.js :: internalSave :: line 323"  data: yes]

I don't think this ever used to happen, so +regression kw.

Comment 1

[Steve England [:stevee]]

"Works" in 20070827_1656_firefox-3.0a8pre.en-US.win32
Broken in 20070827_1712_firefox-3.0a8pre.en-US.win32

Checkins to module PhoenixTinderbox between 2007-08-27 16:56 and 2007-08-27 17:11 :
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1188258960&maxdate=1188259919

Due to bug 389982.


Above, I put "works" in quotes for a reason. It seems that in the 20070827_1656 build, executing step 3 or step 4 results in an error being thrown to the error console multiple (say ten) times before the message stops being spewed and the download suddenly starts. The error is:

Error: [Exception... "'Component does not have requested interface' when calling method: [nsIInterfaceRequestor::getInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "<unknown>"  data: no]

With 20070827_1712 I don't see repeated throwing of the same error message. Instead the download either works, or it doesn't. (First download usually works, subsequent downloads usually don't work. Occasionally the first downloads fails too, tho).

Comment 2

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> Above, I put "works" in quotes for a reason. It seems that in the 20070827_1656
> build, executing step 3 or step 4 results in an error being thrown to the error
> console multiple (say ten) times before the message stops being spewed and the
> download suddenly starts. The error is:
> 
> Error: [Exception... "'Component does not have requested interface' when
> calling method: [nsIInterfaceRequestor::getInterface]"  nsresult: "0x80004002
> (NS_NOINTERFACE)"  location: "<unknown>"  data: no]
That's an xpconnect bug I believe.

Comment 3

[Shawn Wilsher :sdwilsh]

d'oh.  Silly me - QueryInteface != QueryInterface (missing r)

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 5

[Asaf Romano (gone)]

Comment on attachment 278854 [details] [diff] [review]
v1.0

r=mano, you shouldn't be waiting for reviews for this sort of patches though...

Comment 6

[Shawn Wilsher :sdwilsh]

The situation only occurs if the download manager was already open.  Hardly worth a litmus test....

We really need to get some automated UI tests for DM RSN as that would have probably caught this right away :/

Comment 7

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/downloads/src/nsDownloadManagerUI.js;
new revision: 1.2; previous revision: 1.1

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007082923 Minefield/3.0a8pre

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007082923 Minefield/3.0a8pre