Closed
Bug 394241
Opened 18 years ago
Closed 17 years ago
Add a closeDatabase() method to mozStorage
Categories
(Core :: SQLite and Embedded Database Bindings, defect)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: sheppy, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
|
6.01 KB,
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
Given all the warnings about how the database can be corrupted if you open it from multiple threads, it's a little scary that there's no way to explicitly close the database. Since you're at the mercy of the semi-random nature of the garbage collector to get the database closed, this could be dangerous.
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: nobody → comrade693+bmo
Status: NEW → ASSIGNED
Attachment #278893 -
Flags: review?(sspitzer)
|
|
Assignee | |
Updated•18 years ago
|
Target Milestone: --- → mozilla1.9 M8
Version: unspecified → Trunk
|
||
Comment 2•18 years ago
|
||
Comment on attachment 278893 [details] [diff] [review]
v1.0
r=sspitzer
Attachment #278893 -
Flags: review?(sspitzer) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checking in storage/public/mozIStorageConnection.idl;
new revision: 1.12; previous revision: 1.11
Checking in storage/src/mozStorageConnection.cpp;
new revision: 1.29; previous revision: 1.28
Checking in storage/test/unit/test_storage_connection.js;
new revision: 1.6; previous revision: 1.5
|
Reporter | |
Comment 4•17 years ago
|
||
Now *that's* what I call service. Thanks! :)
|
|
Reporter | |
Comment 5•17 years ago
|
||
Removing doc needed keyword in favor of a new bug that covers the fact that in general we actually need proper documentation for Storage; that bug (bug 399535) is set as blocked by this one.
Keywords: dev-doc-needed
|
||
Updated•6 months ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•