Closed Bug 394241 Opened 12 years ago Closed 12 years ago

Add a closeDatabase() method to mozStorage

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: sheppy, Assigned: sdwilsh)

References

Details

Attachments

(1 file)

Given all the warnings about how the database can be corrupted if you open it from multiple threads, it's a little scary that there's no way to explicitly close the database.  Since you're at the mercy of the semi-random nature of the garbage collector to get the database closed, this could be dangerous.
Attached patch v1.0Splinter Review
Assignee: nobody → comrade693+bmo
Status: NEW → ASSIGNED
Attachment #278893 - Flags: review?(sspitzer)
Target Milestone: --- → mozilla1.9 M8
Version: unspecified → Trunk
Comment on attachment 278893 [details] [diff] [review]
v1.0

r=sspitzer
Attachment #278893 - Flags: review?(sspitzer) → review+
Checking in storage/public/mozIStorageConnection.idl;
new revision: 1.12; previous revision: 1.11
Checking in storage/src/mozStorageConnection.cpp;
new revision: 1.29; previous revision: 1.28
Checking in storage/test/unit/test_storage_connection.js;
new revision: 1.6; previous revision: 1.5
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Now *that's* what I call service.  Thanks! :)
Blocks: 394789
Blocks: 399535
Removing doc needed keyword in favor of a new bug that covers the fact that in general we actually need proper documentation for Storage; that bug (bug 399535) is set as blocked by this one.
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.