Closed Bug 394275 Opened 15 years ago Closed 14 years ago
High surrogate in CSS causes atom table crash on shutdown [@ PL
_DHash Table Finish]
168 bytes, text/html
23.83 KB, text/plain
1.42 KB, patch
|Details | Diff | Splinter Review|
Loading the testcase triggers: ###!!! ASSERTION: Surrogate pair split between fragments: 'Error', file ../../../dist/include/string/nsUTF8Utils.h, line 695 Exiting Firefox then crashes [@ PL_DHashTableFinish] with a random address at the top of the stack. I'm guessing this is a bug in the atom table, similar to bug bug 377360 (which is fixed). It's possible that the CSS parser and/or the textContent setter are being bad too, but I think the strategy is to fix the atom table first.
Assignee: nobody → jst
Flags: blocking1.9? → blocking1.9+
Comment on attachment 279991 [details] [diff] [review] Deal with the case where we have half a surrogate pair at the end of a string Would be great if we could add C++ unit tests for this stuff too. r/sr=me either way.
OS: Mac OS X → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.9 M8
Attachment #279991 - Flags: approval1.9? → approval1.9+
Fix checked in.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This bug does not seem to affect branch.
I agree with sicking -- this should be tested using a C++ unit test (xpcom/tests).
crash test landed http://hg.mozilla.org/mozilla-central/rev/e184c9ab1e46 leaving in-testsuite? for a C++ test.
Flags: in-testsuite? → in-testsuite+
Flags: in-testsuite+ → in-testsuite?
Crash Signature: [@ PL_DHashTableFinish]
You need to log in before you can comment on or make changes to this bug.