394279 - nsRect::Contains() should always succeed if the parameter rect is empty

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Justin Wood (:Callek)]

from mozilla.dev.tech.layout

[e-mail] wrote:
> On Aug 29, 8:03 am, fantasai <[e-mail]> wrote: 
>> ... This means an assertion
>>      frame->GetOverflowRect().Contains(frame->GetRect())
>>    will sometimes fail.
>
> Contains() should always succeed if the parameter rect is empty.
> That's a bug, I'll take a patch for that :-) 

We should fix this :-)

Comment 1

[Justin Wood (:Callek)]

Attachment: v1

I don't have my msvc properly re-setup yet, so did not actually test the compile, but this should still be right.

Comment 2

[Justin Wood (:Callek)]

Attachment: v1.1

sorry, had a moment of mental idiocy (checked if the wrong nsRect was empty in prior patch)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

rerequest review when you've tested it

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 278916 [details] [diff] [review]
v1.1

tested, appears fine.

Comment 5

[Reed Loden [:reed]]

Checking in gfx/src/nsRect.cpp;
/cvsroot/mozilla/gfx/src/nsRect.cpp,v  <--  nsRect.cpp
new revision: 3.21; previous revision: 3.20
done