http://www.mozilla.org/download redirects not working correctly

RESOLVED FIXED

Status

defect
--
major
RESOLVED FIXED
12 years ago
7 years ago

People

(Reporter: jorendorff, Assigned: kairo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

http://www.mozilla.org/download redirects to a page where you can download Mozilla Suite.  "Best of 2003", raves PCWORLD!

It shouldn't redirect at all.  If I understand Apache correctly, the default would be to display http://www.mozilla.org/download.html which I think is the right thing.
Apache Default would be to look for a /download/ directory or file, then only if negotiation is enabled, find download.html.

It appears there's a redirection for /download/ to /products/mozilla1.x/ in place, probably from along time ago, when the product pages were created originally.

It should probably be redirected to download.html or changed to a 410 Gone.
AFAIK, negotiation should be enabled, so removing the redirect should make it go to download.html
Removing download/.htaccess;
/www/mozilla-org/html/download/.htaccess,v  <--  .htaccess
new revision: delete; previous revision: 1.1
done

Maybe this will work? We'll have to wait another day for the nightly clobber to remove it, but we'll see...
Assignee: nobody → reed
No such luck.  Can anyone figure out why it's still redirecting?

Is the .htaccess file still there on the server somehow?
Product: mozilla.org → Websites
It looks like this URL is now being redirected to a non-existant page at:

http://www.mozilla.org/projects/browsers.htmldownload

This should be pointing to the download.html page (or to wherever that page gets redirected if the downloads page is removed).
Summary: http://www.mozilla.org/download redirects to Mozilla Suite → http://www.mozilla.org/download redirects not working correctly
I think we should redirect to projects and make download.html redirect there at the same time. The projects page points to all apps that were available from the download page(s) and mozilla.org is no download site (any more).
A while ago I tried to redirect www.mozilla.org/download to the projects page but it didn't work.  From .htaccess:

RewriteRule ^download(?:/(?:index.html)?)?$ http://www.mozilla.org/projects/ [R]

As mentioned earlier in this bug, something else seems to be going on here.
Why go through mod_rewrite at all and not just use
RedirectMatch permanent ^/download http://www.mozilla.org/projects/
instead?

I think we should reorder the top-level .htaccess some time and sort it by the URL of the redirected pages - the huge list we have right now is hard to navigate.
Reed, can you see if there is a redirect on the server that is conflicting with the redirect in the .htaccess file?

Re comment #8, I think that suggestion is fine once we get the redirects working correctly from .htaccess.
(In reply to comment #9)
> Reed, can you see if there is a redirect on the server that is conflicting with
> the redirect in the .htaccess file?

Yep, there is. I'll be moving all the server-side redirects into .htaccess soon, so everything will be able to be managed from the .htaccess file.
I did this a long time ago...
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
But it redirects to download.html, while all both download/ and download.html should redirect5 to projects/ :-/
Attached is a patch that attempts to fix the problems we've had with the downloads redirects.  It removes one of the duplicate redirects for /downloads and add a redirect for download.html.  Kairo, if this looks good to you I can check it in.
Attachment #359345 - Flags: review?(kairo)
Assignee: reed → david
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 359345 [details] [diff] [review]
Patch to fix download redirect issues

>+Redirect permanent /download.html http://www.mozilla.org/projects/
...
> RewriteRule ^download(?:/(?:index.html)?)?$ http://www.mozilla.org/projects/ [R]


Seems like you could combine these...
If I knew anything about regular expressions I probably could combine them :)
Comment on attachment 359345 [details] [diff] [review]
Patch to fix download redirect issues

This basically should work, but why not simply go with what I proposed in comment #8 for both lines mentioned by reed there?
Kairo, your suggestion in comment #8 is fine with me, I just overlooked it when I posted that last patch.  Do you want to go ahead and check in your change?  I'll probably be unable to get to it myself until later this week.
I just checked in that change, here's an inline diff just for documenting the actual changes:

Index: .htaccess
===================================================================
RCS file: /www/mozilla-org/html/.htaccess,v
retrieving revision 1.153
retrieving revision 1.155
diff -u -3 -p -r1.153 -r1.155
--- .htaccess   25 Dec 2008 04:02:33 -0000      1.153
+++ .htaccess   3 Feb 2009 16:45:15 -0000       1.155
@@ -20,6 +20,7 @@ Redirect permanent /docs/netlib/new-hand
 Redirect permanent /docs/plugin.html http://www.mozilla.org/projects/plugins/
 Redirect permanent /docs/refList/refNSPR/ http://www.mozilla.org/projects/nspr/reference/html/
 Redirect permanent /download-mozilla.html http://developer.mozilla.org/en/docs/Download_Mozilla_Source_Code
+RedirectMatch permanent ^/download http://www.mozilla.org/projects/
 Redirect permanent /glimpsesearch.html http://lxr.mozilla.org/
 Redirect permanent /index2.html http://www.mozilla.org/
 Redirect permanent /my-mozilla.html http://www.mozilla.org/
@@ -757,7 +758,6 @@ RewriteRule ^build(?:/(?:index.html)?)?$
 RewriteRule ^docs/dom(?:/(?:index.html)?)?$ http://developer.mozilla.org/en/docs/About_the_Document_Object_Model [R]
 RewriteRule ^docs/dom/domref(?:/(?:index.html)?)?$ http://developer.mozilla.org/en/docs/Gecko_DOM_Reference [R]
 RewriteRule ^quality/help(?:/(?:index.html)?)?$ http://quality.mozilla.org/get-involved [R]
-RewriteRule ^download(?:/(?:index.html)?)?$ http://www.mozilla.org/projects/ [R]
 RewriteRule ^donate(?:/(?:index.html)?)?$ http://www.mozilla.org/foundation/donate.html [R]
 RewriteRule ^bugs(?:/(?:index.html)?)?$ http://developer.mozilla.org/en/Bug_writing_guidelines [R]
 RewriteRule ^status(?:/(?:index.html)?)?$ https://wiki.mozilla.org/WeeklyUpdates [R]
@@ -791,7 +791,6 @@ Redirect permanent /webtools http://cvs-

 # Redirects to other pages on this site.
 Redirect permanent /mozilla1.x http://www.mozilla.org/products/mozilla1.x
-Redirect permanent /download http://www.mozilla.org/products/mozilla1.x/download
 Redirect permanent /camino http://www.mozilla.org/products/camino
 Redirect permanent /firebird http://www.mozilla.org/products/firebird
 Redirect permanent /firefox http://www.mozilla.org/products/firefox


Marking FIXED, but we should probably check that it works correctly once the site has updated.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Attachment #359345 - Flags: review?(kairo)
Assignee: david → kairo
http://www.mozilla.org/download is bringing up a 404 for me, although other variations of the download URL are working like www.mozilla.org/download.html.
It looks like everything that would have gone to the download/ directory is going 404, all other variations redirect. Somewhat strange. Is there still a download/ directory on the server that might even have a .htaccess by itself or so?
That's not the problem. /downloadfu redirects to /projects no problem. But /download/ doesn't. The regex seems to be a bit weird that way. I've added (/.*)? to the end of it, maybe that will help.
fantasai:
The strange thing is that /downloadfoo/foo.html redirects and /download/foo.html doesn't, which sounds somewhat strange if the possible existence of a /download/ directory doesn't make that difference.
I've CVS-removed download.js and download.html, added in a .htaccess rule that worked fine when I used a substring other than 'download'... There used to be a download directory in CVS. It's empty right now. I don't know if the server still has a copy or what. See http://bonsai-www.mozilla.org/rview.cgi?dir=mozilla-org/html&cvsroot=/www&module=default
Instead of a 404 page, I'm now seeing what looks like a script at

http://www.mozilla.org/download
That's download.js, if I'm not mistaken.
I think we should raise the priority of getting this fixed.  The downloads link gets a lot of traffic and it should go to some page while we're getting the redirects sorted out.

Another question: how many other files can we remove along with the download.html page?  I believe someone mentioned that the VARIABLES file could be removed, but not sure if it's used for other things (like the home page download links?)
Severity: normal → major
VARIABLES (the version number part of it at least) is used for version numbers on the home page. I update it every time we have a Camino release.
I tried to also add a RewriteRule now, but it didn't help either. Interestingly, the archive site seems to redirect to the live site's project list though...
I removed download.js from CVS yesterday. :/ It shouldn't be turning up at all.
Can we purge the server's copy of the website or something?
(In reply to comment #30)
> I removed download.js from CVS yesterday. :/ It shouldn't be turning up at all.
> Can we purge the server's copy of the website or something?

That's done every 24 hours.
(In reply to comment #30)
> I removed download.js from CVS yesterday. :/

Removing download.js caused bug 476990. *sigh*
www.mozilla.org/download is redirecting correctly now.  Can someone else check the various download URLs and verify that things look good to them too?
The redirect doesn't work for me, maybe some webheads have it working and some not?
OK, things seem to work fine now for me - finally. Yesterday I still got download.js here at FOSDEM, but now it redirects fine. yay!
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.