protect navigator.offlineResources with a permission

RESOLVED DUPLICATE of bug 402272

Status

()

Core
DOM
P2
normal
RESOLVED DUPLICATE of bug 402272
11 years ago
5 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Created attachment 278997 [details] [diff] [review]
protect offline apps with a permission

Since navigator.offlineResources lets sites pin data on the user's disk, it should probably be protected by a permission.

The attached patch throws a security exception when the API is accessed without the necessary permissions.
Flags: blocking1.9?
Attachment #278997 - Flags: superreview?(jst)
Attachment #278997 - Flags: review?(jst)
(Assignee)

Updated

11 years ago
Depends on: 394392
Assignee: nobody → dcamp
Flags: blocking1.9? → blocking1.9+

Updated

11 years ago
Attachment #278997 - Flags: superreview?(jst)
Attachment #278997 - Flags: superreview+
Attachment #278997 - Flags: review?(jst)
Attachment #278997 - Flags: review+
Attachment #278997 - Flags: approval1.9+
(Assignee)

Updated

11 years ago
Blocks: 398161
(Assignee)

Updated

11 years ago
Blocks: 397416
(Assignee)

Comment 1

11 years ago
Created attachment 284687 [details] [diff] [review]
test fix

this fix is needed to fix the tests after adding the permission.
Attachment #284687 - Flags: review?(jst)

Updated

11 years ago
Attachment #284687 - Flags: review?(jst) → review+
(Assignee)

Comment 2

11 years ago
Comment on attachment 278997 [details] [diff] [review]
protect offline apps with a permission

Clearing the approval flag.  This is going to get caught up in the upcoming API changes, and this doesn't make sense to commit without UI to manage the permission anyway.
Attachment #278997 - Flags: approval1.9+
Dcamp, what's going on here? Shouldn't we land this to let the UI folks build on it? What priority do you think this should have?
Priority: -- → P2
(Assignee)

Comment 4

11 years ago
This patch has ended up as part of the patch for bug 402272, so we can probably close this bug...
Sold!
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 402272
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.