394384 - "ASSERTION: Textrun was not completely removed from the cache" with non-breaking hyphen

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jesse Ruderman]

Attachment: testcase

If I load the testcase and then quit Firefox (Cmd+Q), I see:

###!!! ASSERTION: Textrun was not completely removed from the cache!: 'aTextRun->mCachedWords == 0', file /Users/jruderman/trunk/mozilla/gfx/thebes/src/gfxTextRunWordCache.cpp, line 560

I think the was the testcase is displayed is wrong, too.  Shouldn't there be a space between the non-breaking hyphen and the 'A'?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This can lead to hard-to-diagnose crashes

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The rendering is correct. CR characters are not linefeeds and do not get converted to spaces. We make them invisible zero-width characters.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This is just an accounting error. We're counting a word in the textrun as referenced by the cache when it's actually not.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This is just an accounting error. We're counting a word in the textrun as referenced by the cache when it's actually not.

Comment 5

[Jesse Ruderman]

So this bug can't actually lead to hard-to-diagnose crashes?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This assertion, in general, points to hard-to-diagnose crashes occurring later. In this case, however, the assertion was firing spuriously so this testcase will not lead to crashes.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 8

[Jesse Ruderman]

Crashtest checked in.