394407 - Unable to print or print preview

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The fix for bug 315687 makes it impossible to print or print preview over here.  When I try to print preview I get "An unknown error occured during printing".  When I try to print to file, I get the same alert, then a crash: http://crash-stats.mozilla.com/report/index/bf0591d9-5778-11dc-8163-001a4bd43ed6?date=2007-08-31-04

I have to wonder why this change made us bail out of printing instead of dividing the numbers by 25.4 and moving right along...  Better yet, profile migration should perhaps do the division?

In any case, printing is definitely a smoketest.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Note that the crash is in the print engine.  We might want a separate bug on that...

Comment 2

[Boris Zbarsky [:bzbarsky]]

So...  The unit over here is set to '1'.  So that's millimeters.  So I shouldn't be hitting this new code anyway.  Unfortunately, the logic from bug 315687 is just wrong:

      success = (sizeUnit == nsIPrintSettings::kPaperSizeInches)
             && (width < 100.0)
             && (height < 100.0);

This means that any time sizeUnit is kPaperSizeMillimeters success ends up false.  You presumably wanted:

      success = (sizeUnit != nsIPrintSettings::kPaperSizeInches ||
                 (width < 100.0 && height < 100.0));

or something?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Though making that change doesn't make the symptoms go away.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hmm.  I just tried backing out bug 315687 locally, and I _still_ get the error dialog.

Comment 5

[Boris Zbarsky [:bzbarsky]]

This is actually a regression from bug 367829.

Comment 6

[Stuart Parmenter]

we should back out 367829 and continue to remove MOZ_ENABLE_POSTSCRIPT ifdefs (bug 394413)

Comment 7

[Boris Zbarsky [:bzbarsky]]

ccing culprits.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed by backing out bug 367829.